diff options
| author | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-16 20:59:41 +0000 |
|---|---|---|
| committer | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-16 20:59:41 +0000 |
| commit | b942f1de3e1dee7a766f375f256eb6bf1680880b (patch) | |
| tree | e478d22a25c70d53bd43a2d81f8f828db49628cb /build/isolate.gypi | |
| parent | 231805a8f19246d585401f991c06be133b43199a (diff) | |
| download | chromium_src-b942f1de3e1dee7a766f375f256eb6bf1680880b.zip chromium_src-b942f1de3e1dee7a766f375f256eb6bf1680880b.tar.gz chromium_src-b942f1de3e1dee7a766f375f256eb6bf1680880b.tar.bz2 | |
Clean up isolate.gypi and use the new -V FOO=<(FOO) format.
This will be useful later once we start providing more variables, so that GYP
do not interfere with the command line.
R=csharp@chromium.org
BUG=
Review URL: https://codereview.chromium.org/14298005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194444 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/isolate.gypi')
| -rw-r--r-- | build/isolate.gypi | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/build/isolate.gypi b/build/isolate.gypi index 83ef854..7b81697 100644 --- a/build/isolate.gypi +++ b/build/isolate.gypi @@ -71,12 +71,16 @@ '<(test_isolation_mode)', # GYP will eliminate duplicate arguments so '<(PRODUCT_DIR)' cannot # be provided twice. To work around this behavior, append '/'. + # # Also have a space after <(PRODUCT_DIR) or visual studio will # escape the argument wrappping " with the \ and merge it into # the following arguments. + # + # Other variables should use the -V FOO=<(FOO) form so frequent + # values, like '0' or '1', aren't stripped out by GYP. '--outdir', '<(PRODUCT_DIR)/ ', '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ', - '--variable', 'OS', '<(OS)', + '--variable', 'OS=<(OS)', '--result', '<@(_outputs)', '--isolate', '<(RULE_INPUT_PATH)', ], @@ -86,11 +90,9 @@ '<(DEPTH)/tools/swarm_client/isolate.py', '<(test_isolation_mode)', '--outdir', '<(test_isolation_outdir)', - # Have a space after <(PRODUCT_DIR) or visual studio will - # escape the argument wrappping " with the \ and merge it into - # the following arguments. + # See comment above. '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ', - '--variable', 'OS', '<(OS)', + '--variable', 'OS=<(OS)', '--result', '<@(_outputs)', '--isolate', '<(RULE_INPUT_PATH)', ], |