diff options
author | newt@chromium.org <newt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-10 21:05:48 +0000 |
---|---|---|
committer | newt@chromium.org <newt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-10 21:05:48 +0000 |
commit | 832fcca9ee8c6ee9e9cd4f4a9dbb28472c40f774 (patch) | |
tree | 9038a42dee1d29607a70f189dbbb87ea3f0ee7fc /build/java_apk.gypi | |
parent | 219c503bb3c190bf3dfcf902d1de38ae9a8b0a71 (diff) | |
download | chromium_src-832fcca9ee8c6ee9e9cd4f4a9dbb28472c40f774.zip chromium_src-832fcca9ee8c6ee9e9cd4f4a9dbb28472c40f774.tar.gz chromium_src-832fcca9ee8c6ee9e9cd4f4a9dbb28472c40f774.tar.bz2 |
Revert 176134
> [Android] Generate localized strings.xml files at build time.
>
> This generates localized strings.xml files (e.g.
> values-fr/strings.xml) from grd and xtb files at build time. This
> means we no longer need to check in localized strings.xml files. Note:
> the xtb files are empty until translations are available.
>
> Benefits:
> - 41 fewer extraneous results when grepping Java string IDs
> - Switching from maintaining strings in strings.xml over to using a
> grd file is One Trivial CL* away: just include English in the list
> of languages for which we generate strings.xml files.
>
> *Restrictions may apply
>
> BUG=167248
>
> Review URL: https://codereview.chromium.org/11659006
TBR=newt@chromium.org
Review URL: https://codereview.chromium.org/11820058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176151 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/java_apk.gypi')
-rw-r--r-- | build/java_apk.gypi | 51 |
1 files changed, 10 insertions, 41 deletions
diff --git a/build/java_apk.gypi b/build/java_apk.gypi index 9edd420..6d39188 100644 --- a/build/java_apk.gypi +++ b/build/java_apk.gypi @@ -59,8 +59,6 @@ # resource_dir - The directory for resources. # R_package - A custom Java package to generate the resource file R.java in. # By default, the package given in AndroidManifest.xml will be used. -# java_strings_grd - The name of the grd file from which to generate localized -# strings.xml files, if any. { 'variables': { @@ -80,8 +78,6 @@ 'additional_res_dirs': [], 'additional_res_packages': [], 'is_test_apk%': 0, - 'java_strings_grd%': '', - 'grit_grd_file%': '', }, 'sources': [ '<@(native_libs_paths)' @@ -115,35 +111,6 @@ ], }, ], - 'conditions': [ - ['R_package != ""', { - 'variables': { - # We generate R.java in package R_package (in addition to the package - # listed in the AndroidManifest.xml, which is unavoidable). - 'additional_res_dirs': ['<(DEPTH)/build/android/ant/empty/res'], - 'additional_res_packages': ['<(R_package)'], - }, - }], - ['java_strings_grd != ""', { - 'variables': { - 'out_res_dir': '<(SHARED_INTERMEDIATE_DIR)/<(package_name)_apk/res', - 'additional_res_dirs': ['<(out_res_dir)'], - # grit_grd_file is used by grit_action.gypi, included below. - 'grit_grd_file': '<(java_in_dir)/strings/<(java_strings_grd)', - }, - 'actions': [ - { - 'action_name': 'generate_localized_strings_xml', - 'variables': { - 'grit_out_dir': '<(out_res_dir)', - # resource_ids is unneeded since we don't generate .h headers. - 'grit_resource_ids': '', - }, - 'includes': ['../build/grit_action.gypi'], - }, - ], - }], - ], 'actions': [ { 'action_name': 'ant_<(package_name)_apk', @@ -164,14 +131,6 @@ ['resource_dir!=""', { 'inputs': ['<!@(find <(java_in_dir)/<(resource_dir) -name "*")'] }], - ['java_strings_grd != ""', { - 'inputs': [ - # TODO(newt): replace this with .../values/strings.xml once - # the English strings.xml is generated as well? That would be - # simpler and faster and should be equivalent. - '<!@pymod_do_main(grit_info <@(grit_defines) --outputs "<(out_res_dir)" <(grit_grd_file))', - ], - }], ['is_test_apk == 1', { 'variables': { 'additional_res_dirs=': [], @@ -223,4 +182,14 @@ ] }, ], + 'conditions': [ + ['R_package != ""', { + 'variables': { + # We generate R.java in package R_package (in addition to the package + # listed in the AndroidManifest.xml, which is unavoidable). + 'additional_res_dirs': ['<(DEPTH)/build/android/ant/empty/res'], + 'additional_res_packages': ['<(R_package)'], + }, + }], + ], } |