diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-02 20:22:16 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-02 20:22:16 +0000 |
| commit | 4037bbc17a6e403af4d105a5586135aebd2a606f (patch) | |
| tree | 1070f16729e6f666ddd412aaf1ddb37f17539f66 /build/java_prebuilt.gypi | |
| parent | 0d36af0279717aa3463a0d865eb5b5e774ddb441 (diff) | |
| download | chromium_src-4037bbc17a6e403af4d105a5586135aebd2a606f.zip chromium_src-4037bbc17a6e403af4d105a5586135aebd2a606f.tar.gz chromium_src-4037bbc17a6e403af4d105a5586135aebd2a606f.tar.bz2 | |
android: Remove a few unnecessary md5sum invocations.
When the list of implicit inputs of a build edge shrinks, ninja doesn't
rerun it. The Android build uses complex build actions (e.g. ant) whose
output depend on directory contents and whatnot, and the Android build
by adding "dir/*.java" or similar as implicit inputs. So it's important
that ninja does rerun these actions when their list of implicit inputs
shrinks. As a workaround, the Android build passes the md5 of the list of
implicit inputs as "--ignored" parameter to the build action (ninja does
rerun edges whose commandline changes.)
Due to copypasta, this --ignored flag is used in a few places where it's
not actually used (on edges where all inputs are already passed as regular
commandline parameters).
Also remove the --ignored parameter from proguard.py as nothing passes it
any more.
BUG=177552
NOTRY=true
Review URL: https://codereview.chromium.org/175683005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254414 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/java_prebuilt.gypi')
| -rw-r--r-- | build/java_prebuilt.gypi | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/build/java_prebuilt.gypi b/build/java_prebuilt.gypi index cec881d..770239d 100644 --- a/build/java_prebuilt.gypi +++ b/build/java_prebuilt.gypi @@ -72,9 +72,6 @@ '--output-path=<(dex_input_jar_path)', '--proguard-config=<(proguard_config)', '--classpath=>(input_jars_paths)', - - # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja. - '--ignore=>!(echo \'>(_inputs)\' | md5sum)', ] }, ], @@ -96,10 +93,6 @@ 'python', '<(DEPTH)/build/android/gyp/dex.py', '--dex-path=<(dex_path)', '--android-sdk-tools=<(android_sdk_tools)', - - # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja. - '--ignore=>!(echo \'>(_inputs)\' | md5sum)', - '<(dex_input_jar_path)', ] }, |