diff options
| author | mmoss@chromium.org <mmoss@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-12 19:21:20 +0000 |
|---|---|---|
| committer | mmoss@chromium.org <mmoss@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-12 19:21:20 +0000 |
| commit | c2512482d0708c7a00307650194634e51b9beb60 (patch) | |
| tree | 340d98a5b080170ebe7da4a76301fdae3004a91a /build/linux/dump_app_syms | |
| parent | adca6ba1a59eadfb8e8d49b7411cc78f980cf04a (diff) | |
| download | chromium_src-c2512482d0708c7a00307650194634e51b9beb60.zip chromium_src-c2512482d0708c7a00307650194634e51b9beb60.tar.gz chromium_src-c2512482d0708c7a00307650194634e51b9beb60.tar.bz2 | |
Cleanups from post-submit suggestions.
Review URL: http://codereview.chromium.org/126062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18303 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/linux/dump_app_syms')
| -rwxr-xr-x | build/linux/dump_app_syms | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/build/linux/dump_app_syms b/build/linux/dump_app_syms index 85544be..1ebac58 100755 --- a/build/linux/dump_app_syms +++ b/build/linux/dump_app_syms @@ -10,7 +10,7 @@ set -e usage() { - echo "$0 <dump_syms_exe> <binary_with_symbols> <symbols_output>" + echo "$0 <dump_syms_exe> <binary_with_symbols> <symbols_output>" >&2 } @@ -26,12 +26,14 @@ OUTFILE="$3" STRIPPED=$(mktemp -q -t stripped-XXXXX) if [ $? -ne 0 ]; then - echo "ERROR: Could not create temp stripped '$INFILE'" + echo "ERROR: Could not create temp stripped '$INFILE'" >&2 exit 1 fi # Dump the symbols from the given binary. -"$DUMPSYMS" "$INFILE" > "$OUTFILE" +if [ "$INFILE" -nt "$OUTFILE" ]; then + "$DUMPSYMS" "$INFILE" > "$OUTFILE" +fi # Strip the binary and calculate the signature of that, since that's what ships. strip "$INFILE" -o "$STRIPPED" @@ -39,6 +41,4 @@ NEWSIG=$("$SCRIPTDIR/dump_signature.py" "$STRIPPED") rm "$STRIPPED" # Replace the old signature with the stripped signature in the symbols file. -INFILE_BASE=$(basename "$INFILE") -sed -i "1s/[0-9A-F]* $INFILE_BASE/$NEWSIG $INFILE_BASE/" "$OUTFILE" - +sed -i "1s/ [0-9A-F]* / $NEWSIG /" "$OUTFILE" |