summaryrefslogtreecommitdiffstats
path: root/build/linux
diff options
context:
space:
mode:
authorpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-10 19:37:13 +0000
committerpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-10 19:37:13 +0000
commitb38c1a77d72ca6e1804b212ee45f48bee6c3e3e3 (patch)
tree0ef462cc84408074e4e3180be7aa4451a18c15ee /build/linux
parent08810256fa07705b59d94cfe0e4d6d7a73f8a0bd (diff)
downloadchromium_src-b38c1a77d72ca6e1804b212ee45f48bee6c3e3e3.zip
chromium_src-b38c1a77d72ca6e1804b212ee45f48bee6c3e3e3.tar.gz
chromium_src-b38c1a77d72ca6e1804b212ee45f48bee6c3e3e3.tar.bz2
Revert 95910 - Revert 95907 - Clean up SSL false start blacklist code.
Now that r96121 has landed, this should not cause compile failures when compiling base/ on the host. Original comments follow. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7529035 TBR=fischman@chromium.org Review URL: http://codereview.chromium.org/7587003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96211 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/linux')
-rw-r--r--build/linux/system.gyp72
1 files changed, 56 insertions, 16 deletions
diff --git a/build/linux/system.gyp b/build/linux/system.gyp
index e87e1a7..3b667d0 100644
--- a/build/linux/system.gyp
+++ b/build/linux/system.gyp
@@ -31,6 +31,7 @@
{
'target_name': 'gtk',
'type': 'settings',
+ 'toolsets': ['host', 'target'],
'conditions': [
['_toolset=="target"', {
'direct_dependent_settings': {
@@ -46,12 +47,27 @@
'<!@(<(pkg-config) --libs-only-l gtk+-2.0 gthread-2.0)',
],
},
- }],
- [ 'chromeos==1', {
- 'link_settings': {
- 'libraries': [ '-lXtst' ]
- }
- }]]
+ }, {
+ 'direct_dependent_settings': {
+ 'cflags': [
+ '<!@(pkg-config --cflags gtk+-2.0 gthread-2.0)',
+ ],
+ },
+ 'link_settings': {
+ 'ldflags': [
+ '<!@(pkg-config --libs-only-L --libs-only-other gtk+-2.0 gthread-2.0)',
+ ],
+ 'libraries': [
+ '<!@(pkg-config --libs-only-l gtk+-2.0 gthread-2.0)',
+ ],
+ },
+ }],
+ ['chromeos==1', {
+ 'link_settings': {
+ 'libraries': [ '-lXtst' ]
+ }
+ }],
+ ],
},
{
'target_name': 'gtkprint',
@@ -71,7 +87,8 @@
'<!@(<(pkg-config) --libs-only-l gtk+-unix-print-2.0)',
],
},
- }]]
+ }],
+ ],
},
{
'target_name': 'ssl',
@@ -152,7 +169,8 @@
'<!@(<(pkg-config) --libs-only-l freetype2)',
],
},
- }]]
+ }],
+ ],
},
{
'target_name': 'fontconfig',
@@ -172,7 +190,8 @@
'<!@(<(pkg-config) --libs-only-l fontconfig)',
],
},
- }]]
+ }],
+ ],
},
{
'target_name': 'gdk',
@@ -192,7 +211,8 @@
'<!@(<(pkg-config) --libs-only-l gdk-2.0)',
],
},
- }]]
+ }],
+ ],
},
{
'target_name': 'gconf',
@@ -215,7 +235,8 @@
'<!@(<(pkg-config) --libs-only-l gconf-2.0)',
],
},
- }]]
+ }],
+ ],
},
{
'target_name': 'gio',
@@ -250,11 +271,13 @@
}],
],
},
- }]]
+ }],
+ ],
},
{
'target_name': 'x11',
'type': 'settings',
+ 'toolsets': ['host', 'target'],
'conditions': [
['_toolset=="target"', {
'direct_dependent_settings': {
@@ -270,7 +293,21 @@
'<!@(<(pkg-config) --libs-only-l x11 xi)',
],
},
- }],
+ }, {
+ 'direct_dependent_settings': {
+ 'cflags': [
+ '<!@(pkg-config --cflags x11)',
+ ],
+ },
+ 'link_settings': {
+ 'ldflags': [
+ '<!@(pkg-config --libs-only-L --libs-only-other x11 xi)',
+ ],
+ 'libraries': [
+ '<!@(pkg-config --libs-only-l x11 xi)',
+ ],
+ },
+ }],
],
},
{
@@ -291,7 +328,8 @@
'<!@(<(pkg-config) --libs-only-l xext)',
],
},
- }]]
+ }],
+ ],
},
{
'target_name': 'libgcrypt',
@@ -308,7 +346,8 @@
'<!@(libgcrypt-config --libs)',
],
},
- }]]
+ }],
+ ],
},
{
'target_name': 'selinux',
@@ -320,7 +359,8 @@
'-lselinux',
],
},
- }]]
+ }],
+ ],
},
{
'target_name': 'gnome_keyring',