summaryrefslogtreecommitdiffstats
path: root/build/mac
diff options
context:
space:
mode:
authorsatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-24 03:32:06 +0000
committersatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-08-24 03:32:06 +0000
commit06ead8788ef8d9ea7e5db736d563a7fb25df059d (patch)
tree4ddbcc90d432a750f0458b63f2e7f1074d405e48 /build/mac
parent313bbf5ef2c0a1c428e3d92847c1b4b665b71706 (diff)
downloadchromium_src-06ead8788ef8d9ea7e5db736d563a7fb25df059d.zip
chromium_src-06ead8788ef8d9ea7e5db736d563a7fb25df059d.tar.gz
chromium_src-06ead8788ef8d9ea7e5db736d563a7fb25df059d.tar.bz2
Fix design shortcomings in Message classes.
- Prohibit to instantiate Message class. Rationale: this is not corresponding to any D-Bus message types. - Get rid of Message::reset_raw_message() Rationale: this was breaking encapsulation. For instance, It was possible to inject a DBUS_MESSAGE_TYPE_ERROR raw message to a MethodCall message, which should not be allowed. - Prohibit to instantiate Response/ErrorResponse with NULL raw message. Rationale: Message objects should be backed up by valid raw messages. - Change Object::CallMethodAndBlock() to return Response*. Rationale: the original API requred a Response object with raw_message_ set to NULL, which we no longer allow. - Add message_type header to ToString(). BUG=90036 TEST=dbus_unittests Review URL: http://codereview.chromium.org/7709009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97983 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/mac')
0 files changed, 0 insertions, 0 deletions