diff options
| author | rmcilroy@chromium.org <rmcilroy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-07 11:47:00 +0000 |
|---|---|---|
| committer | rmcilroy@chromium.org <rmcilroy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-07 11:47:00 +0000 |
| commit | d3ee991e4f9ac29350ceb112012123c8d9d766a8 (patch) | |
| tree | 398d9e92d80ab60808e8ad3595c3e744a6a36128 /build/util | |
| parent | f9d3bcb6d72a7777d6b833134f6c424938bb7429 (diff) | |
| download | chromium_src-d3ee991e4f9ac29350ceb112012123c8d9d766a8.zip chromium_src-d3ee991e4f9ac29350ceb112012123c8d9d766a8.tar.gz chromium_src-d3ee991e4f9ac29350ceb112012123c8d9d766a8.tar.bz2 | |
Telemetry: Check in PrintPerfResult that the flattened list is also non-zero.
BUG=304335
Review URL: https://codereview.chromium.org/25999004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227271 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/util')
| -rw-r--r-- | build/util/lib/common/perf_tests_results_helper.py | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/build/util/lib/common/perf_tests_results_helper.py b/build/util/lib/common/perf_tests_results_helper.py index cec4f69..9012f18 100644 --- a/build/util/lib/common/perf_tests_results_helper.py +++ b/build/util/lib/common/perf_tests_results_helper.py @@ -25,12 +25,12 @@ def _EscapePerfResult(s): return re.sub('[\:|=/#&,]', '_', s) -def _Flatten(values): +def FlattenList(values): """Returns a simple list without sub-lists.""" ret = [] for entry in values: if isinstance(entry, list): - ret.extend(_Flatten(entry)) + ret.extend(FlattenList(entry)) else: ret.append(entry) return ret @@ -120,9 +120,10 @@ def PrintPerfResult(measurement, trace, values, units, result_type == perf_result_data_type.DEFAULT or result_type == perf_result_data_type.INFORMATIONAL): assert isinstance(values, list) - assert len(values) assert '/' not in measurement - value, avg, sd = _MeanAndStdDevFromList(_Flatten(values)) + flattened_values = FlattenList(values) + assert len(flattened_values) + value, avg, sd = _MeanAndStdDevFromList(flattened_values) output = '%s%s: %s%s%s %s' % ( RESULT_TYPES[result_type], _EscapePerfResult(measurement), |