diff options
author | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-03 02:04:11 +0000 |
---|---|---|
committer | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-03 02:04:11 +0000 |
commit | 942c3a60fab777c3bc83342a932b940f81ebdbb7 (patch) | |
tree | d5e6d82482c7e17a47411e55dc548763d5eaa6ce /build | |
parent | 413eb8709a131c09ad425f344e9a0eb200674393 (diff) | |
download | chromium_src-942c3a60fab777c3bc83342a932b940f81ebdbb7.zip chromium_src-942c3a60fab777c3bc83342a932b940f81ebdbb7.tar.gz chromium_src-942c3a60fab777c3bc83342a932b940f81ebdbb7.tar.bz2 |
Increase warning level to 4 on Visual Studio
This requires disabling most /W4 warnings so the patch doesn't get too large.
I still fixed a few bugs so I didn't have to disable some more serious warnings. Most of these warnings are already enabled on gcc so it's mostly windows-specific code that is affected.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6902069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83840 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
-rw-r--r-- | build/common.gypi | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/build/common.gypi b/build/common.gypi index ae85b47..81f2dca 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -758,7 +758,8 @@ 'msvs_disabled_warnings': [4800], 'msvs_settings': { 'VCCLCompilerTool': { - 'WarnAsError': 'false', + 'WarningLevel': '3', + 'WarnAsError': 'false', # TODO(maruel): Enable it. 'Detect64BitPortabilityProblems': 'false', }, }, @@ -1515,14 +1516,20 @@ '$(VSInstallDir)/VC/atlmfc/include', ], 'msvs_cygwin_dirs': ['<(DEPTH)/third_party/cygwin'], - 'msvs_disabled_warnings': [4351, 4396, 4503, 4819], + 'msvs_disabled_warnings': [4351, 4396, 4503, 4819, + # TODO(maruel): These warnings are level 4. They will be slowly + # removed as code is fixed. + 4100, 4121, 4125, 4127, 4130, 4131, 4189, 4201, 4238, 4244, 4245, + 4310, 4355, 4428, 4481, 4505, 4510, 4512, 4530, 4610, 4611, 4701, + 4702, 4706, + ], 'msvs_settings': { 'VCCLCompilerTool': { 'MinimalRebuild': 'false', 'BufferSecurityCheck': 'true', 'EnableFunctionLevelLinking': 'true', 'RuntimeTypeInfo': 'false', - 'WarningLevel': '3', + 'WarningLevel': '4', 'WarnAsError': 'true', 'DebugInformationFormat': '3', 'conditions': [ |