diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-19 01:58:57 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-19 01:58:57 +0000 |
| commit | 1a45d2208d1203f3bfb4aebaed813eebb90b63c2 (patch) | |
| tree | 021476e95de9f4ecfd4aa39a62499a3b65febf47 /build | |
| parent | d2ed2383f5820e1fc26c9ac709b00bc8cdc8d086 (diff) | |
| download | chromium_src-1a45d2208d1203f3bfb4aebaed813eebb90b63c2.zip chromium_src-1a45d2208d1203f3bfb4aebaed813eebb90b63c2.tar.gz chromium_src-1a45d2208d1203f3bfb4aebaed813eebb90b63c2.tar.bz2 | |
build-bisect: minor usability tweaks
1) Show the list of buildtype choices in the --help output.
Looks like this:
-a ARCHIVE, --archive=ARCHIVE
The buildbot archive to bisect
[mac|xp|linux|linux-64].
2) Always use a new profile when running.
Review URL: http://codereview.chromium.org/205022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26648 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rwxr-xr-x | build/build-bisect.py | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/build/build-bisect.py b/build/build-bisect.py index 6eddf6d..29bbfd4 100755 --- a/build/build-bisect.py +++ b/build/build-bisect.py @@ -112,14 +112,16 @@ def TryRevision(rev): os.system("unzip -q %s" % BUILD_ZIP_NAME) # Tell the system to open the app. - print 'Running %s/%s/%s' % (os.getcwd(), BUILD_DIR_NAME, BUILD_EXE_NAME) + flags = '--user-data-dir=profile' + print 'Running %s/%s/%s %s' % (os.getcwd(), BUILD_DIR_NAME, BUILD_EXE_NAME, + flags) if BUILD_ARCHIVE_TYPE in ('linux', 'linux-64'): - os.system("%s/%s" % (BUILD_DIR_NAME, BUILD_EXE_NAME)) + os.system("%s/%s %s" % (BUILD_DIR_NAME, BUILD_EXE_NAME, flags)) elif BUILD_ARCHIVE_TYPE in ('mac'): - os.system("open %s/%s" % (BUILD_DIR_NAME, BUILD_EXE_NAME)) + os.system("open %s/%s %s" % (BUILD_DIR_NAME, BUILD_EXE_NAME, flags)) elif BUILD_ARCHIVE_TYPE in ('xp'): # TODO(mmoss) Does Windows need 'start' or something? - os.system("%s/%s" % (BUILD_DIR_NAME, BUILD_EXE_NAME)) + os.system("%s/%s %s" % (BUILD_DIR_NAME, BUILD_EXE_NAME, flags)) os.chdir(cwd) print 'Cleaning temp dir ...' @@ -141,9 +143,12 @@ def main(): usage = ('%prog [options]\n' 'Perform binary search on the snapshot builds.') parser = optparse.OptionParser(usage=usage) + # Strangely, the default help output doesn't include the choice list. + choices = ['mac', 'xp', 'linux', 'linux-64'] parser.add_option('-a', '--archive', - choices = ['mac', 'xp', 'linux', 'linux-64'], - help = 'The buildbot archive to bisect.') + choices = choices, + help = 'The buildbot archive to bisect [%s].' % + '|'.join(choices)) parser.add_option('-b', '--bad', type = 'int', help = 'The bad revision to bisect to.') parser.add_option('-g', '--good', type = 'int', |