summaryrefslogtreecommitdiffstats
path: root/build
diff options
context:
space:
mode:
authorcbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-14 18:46:59 +0000
committercbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-14 18:46:59 +0000
commita450f1bea7dfdb72b6d76298166c4bbeb46caa4b (patch)
tree4479693955449969eff17f7b822933e0ebd695b0 /build
parenta16579a74c567d7bfe7cc6dc11ea6259d6371016 (diff)
downloadchromium_src-a450f1bea7dfdb72b6d76298166c4bbeb46caa4b.zip
chromium_src-a450f1bea7dfdb72b6d76298166c4bbeb46caa4b.tar.gz
chromium_src-a450f1bea7dfdb72b6d76298166c4bbeb46caa4b.tar.bz2
patch from issue 3527003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62603 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
-rw-r--r--build/common.gypi6
1 files changed, 6 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi
index 9f87a44..c376cb6 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -874,6 +874,7 @@
# Make inline functions have hidden visiblity by default.
# Surprisingly, not covered by -fvisibility=hidden.
'-fvisibility-inlines-hidden',
+ '-Wno-non-virtual-dtor',
],
'ldflags': [
'-pthread', '-Wl,-z,noexecstack',
@@ -1237,6 +1238,11 @@
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
'GCC_VERSION': '4.2',
'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
+ # TODO(cbentzel): http://crbug.com/45135
+ # Enable non virtual destructor warning on OSX.
+ # It's gcc implementation currently warns about more violations
+ # than Linux's gcc implementation.
+ #'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wno-non-virtual-dtor
# MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min
'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
'PREBINDING': 'NO', # No -Wl,-prebind