diff options
| author | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-09 22:51:41 +0000 |
|---|---|---|
| committer | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-09 22:51:41 +0000 |
| commit | 0ac8fce3591b1a72231c83827811aacd43121089 (patch) | |
| tree | ed0cead7153d82a10d7f89ad255f43ac908fefdc /build | |
| parent | 6aa9349ef5c1110d9c096945840e6a105e8a8295 (diff) | |
| download | chromium_src-0ac8fce3591b1a72231c83827811aacd43121089.zip chromium_src-0ac8fce3591b1a72231c83827811aacd43121089.tar.gz chromium_src-0ac8fce3591b1a72231c83827811aacd43121089.tar.bz2 | |
Restore -Wall to Linux build and set up for -Werror.
* Add -Wall to build/common.gypi (and -Werror, commented out for now).
* Have build/external_code.gypi remove -Wall (and -Werror).
* Remove chromium_code definition from build/all.gyp.
* Remove chromium_code definitions from third_party/ *.gyp files.
* Remove scons-specific -Werror removal in webkit.gyp.
* Remove unused variables from:
base/clipboard_linux.cc
chrome/browser/gtk/download_shelf_gtk.cc
chrome/browser/gtk/bookmark_bar_gtk.cc
Review URL: http://codereview.chromium.org/66001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13478 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/all.gyp | 1 | ||||
| -rw-r--r-- | build/common.gypi | 3 | ||||
| -rw-r--r-- | build/external_code.gypi | 8 |
3 files changed, 11 insertions, 1 deletions
diff --git a/build/all.gyp b/build/all.gyp index fefcc17..feec2e3 100644 --- a/build/all.gyp +++ b/build/all.gyp @@ -4,7 +4,6 @@ { 'variables': { - 'chromium_code': 1, 'conditions': [ ['OS!="win"', { 'all_gyps%': 1, diff --git a/build/common.gypi b/build/common.gypi index 93565f3..40ce2fd 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -169,6 +169,9 @@ '-fno-exceptions', '-msse2', '-mfpmath=sse', + '-Wall', + # TODO(sgk): when chromium_code targets are clean of warnings. + #'-Werror', ], 'ldflags': [ '-m32', diff --git a/build/external_code.gypi b/build/external_code.gypi index ca16f86..053fb61 100644 --- a/build/external_code.gypi +++ b/build/external_code.gypi @@ -4,6 +4,14 @@ { 'conditions': [ + [ 'OS=="linux"', { + 'target_defaults': { + 'cflags!': [ + '-Wall', + '-Werror', + ], + }, + }], [ 'OS=="win"', { 'target_defaults': { 'defines': [ |