diff options
| author | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-21 15:19:04 +0000 |
|---|---|---|
| committer | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-21 15:19:04 +0000 |
| commit | 080e86faa082c7d2fb8a935c8e189fbb7d1a23c9 (patch) | |
| tree | a179a2f7457564df93bd1d08baa23b305b6f3af2 /build | |
| parent | 05b6239f408bdee63ca049e441e46ba2e1ea38c9 (diff) | |
| download | chromium_src-080e86faa082c7d2fb8a935c8e189fbb7d1a23c9.zip chromium_src-080e86faa082c7d2fb8a935c8e189fbb7d1a23c9.tar.gz chromium_src-080e86faa082c7d2fb8a935c8e189fbb7d1a23c9.tar.bz2 | |
[Mac] force -Wextra on for all chromium code. Not bothering with a local switch since there shouldn't be a reason to allow overrides of this.
BUG=34160
TEST=none
Review URL: http://codereview.chromium.org/2854013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 25 |
1 files changed, 10 insertions, 15 deletions
diff --git a/build/common.gypi b/build/common.gypi index e2da12b..0941750 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -166,10 +166,6 @@ 'mac_sdk%': '10.5', 'mac_deployment_target%': '10.5', - # Turn on -Wextra on chromium code during Mac compile. - # TODO(mark,tvl): drop this and turn it always on when it works. - 'chromium_mac_wextra%': 0, - # Set to 1 to enable code coverage. In addition to build changes # (e.g. extra CFLAGS), also creates a new target in the src/chrome # project file called "coverage". @@ -1146,21 +1142,20 @@ 'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)', 'PREBINDING': 'NO', # No -Wl,-prebind 'USE_HEADERMAP': 'NO', - 'WARNING_CFLAGS': ['-Wall', '-Wendif-labels'], + 'WARNING_CFLAGS': [ + '-Wall', + '-Wendif-labels', + '-Wextra', + # Don't warn about unused function parameters. + '-Wno-unused-parameter', + # Don't warn about the "struct foo f = {0};" initialization + # pattern. + '-Wno-missing-field-initializers', + ], 'conditions': [ ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'}, {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'} ], - ['chromium_mac_wextra', { - 'WARNING_CFLAGS': [ - '-Wextra', - # Don't warn about unused function params. Used everywhere. - '-Wno-unused-parameter', - # Don't warn about the "struct foo f = {0};" initialization - # pattern. - '-Wno-missing-field-initializers', - ] - }], ], }, 'target_conditions': [ |