diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-02 21:26:50 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-02 21:26:50 +0000 |
| commit | a48b8d81e330852504ef0af9ac9ac1ef5101719f (patch) | |
| tree | 29bad8c36621991cf872bc40d04179b276ec031d /build | |
| parent | bafc0b68238b21b5a45a9d76428da06de3c6fe3c (diff) | |
| download | chromium_src-a48b8d81e330852504ef0af9ac9ac1ef5101719f.zip chromium_src-a48b8d81e330852504ef0af9ac9ac1ef5101719f.tar.gz chromium_src-a48b8d81e330852504ef0af9ac9ac1ef5101719f.tar.bz2 | |
GTTF: Enable glibcxx debug mode for Debug builds by default.
This will help us catch problems earlier.
BUG=65151
TEST=none
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/11276032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215369 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/build/common.gypi b/build/common.gypi index 7cbe6b2..4097232 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -976,8 +976,6 @@ # Profile without optimizing out stack frames when profiling==1. 'profiling_full_stack_frames%': '0', - # Enable strict glibc debug mode. - 'glibcxx_debug%': 0, # And if we want to dump symbols for Breakpad-enabled builds. 'linux_dump_symbols%': 0, # And if we want to strip the binary after dumping symbols. @@ -1966,10 +1964,6 @@ ['profiling==1', { 'defines': ['ENABLE_PROFILING=1'], }], - ['OS=="linux" and glibcxx_debug==1', { - 'defines': ['_GLIBCXX_DEBUG=1',], - 'cflags_cc+': ['-g'], - }], ['remoting==1', { 'defines': ['ENABLE_REMOTING=1'], }], @@ -2553,6 +2547,13 @@ }], ], }], + ['OS=="linux"', { + # Enable libstdc++ debugging facilities to help catch problems + # early, see http://crbug.com/65151 . + # TODO(phajdan.jr): Should we enable this for all of POSIX? + 'defines': ['_GLIBCXX_DEBUG=1',], + 'cflags_cc+': ['-g'], + }], # Disabled on iOS because it was causing a crash on startup. # TODO(michelea): investigate, create a reduced test and possibly # submit a radar. |