diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-05 22:23:20 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-05 22:23:20 +0000 |
| commit | 225c8f507421a2eff2ed7a900104431d04ed7e5e (patch) | |
| tree | 770b7081fc8f2a15abe4635938e03550f010a526 /build | |
| parent | f3f0c05dfbcbfec2ecbb79ba9bab6ffc8f93ea32 (diff) | |
| download | chromium_src-225c8f507421a2eff2ed7a900104431d04ed7e5e.zip chromium_src-225c8f507421a2eff2ed7a900104431d04ed7e5e.tar.gz chromium_src-225c8f507421a2eff2ed7a900104431d04ed7e5e.tar.bz2 | |
linux: build with -Wextra
95% of this is removing "const" from return types, but turning this
on found one bug! (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)
BUG=34160
Review URL: http://codereview.chromium.org/570012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 8 | ||||
| -rw-r--r-- | build/external_code.gypi | 3 |
2 files changed, 9 insertions, 2 deletions
diff --git a/build/common.gypi b/build/common.gypi index 877679b..5d96ae5 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -1,4 +1,4 @@ -# Copyright (c) 2009 The Chromium Authors. All rights reserved. +# Copyright (c) 2010 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -602,6 +602,12 @@ '-pthread', '-fno-exceptions', '-Wall', + # TODO(evan): turn this back on once the v8 change lands. + #'-Wextra', + # Don't warn about unused function params. We use those everywhere. + '-Wno-unused-parameter', + # Don't warn about the "struct foo f = {0};" initialization pattern. + '-Wno-missing-field-initializers', '-D_FILE_OFFSET_BITS=64', # Don't export any symbols (for example, to plugins we dlopen()). # Note: this is *required* to make some plugins work. diff --git a/build/external_code.gypi b/build/external_code.gypi index c45603b..4f59b2b 100644 --- a/build/external_code.gypi +++ b/build/external_code.gypi @@ -1,4 +1,4 @@ -# Copyright (c) 2009 The Chromium Authors. All rights reserved. +# Copyright (c) 2010 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -8,6 +8,7 @@ 'target_defaults': { 'cflags!': [ '-Wall', + '-Wextra', '-Werror', ], }, |