diff options
| author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-14 10:36:28 +0000 |
|---|---|---|
| committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-14 10:36:28 +0000 |
| commit | 515f2492fbc0a023eb089e91e349106da325de5e (patch) | |
| tree | d606fd354fe6c4695fe2f635e62774fe582e8232 /build | |
| parent | a834a1abc0a318a563d9a0eb3adec0df2947a982 (diff) | |
| download | chromium_src-515f2492fbc0a023eb089e91e349106da325de5e.zip chromium_src-515f2492fbc0a023eb089e91e349106da325de5e.tar.gz chromium_src-515f2492fbc0a023eb089e91e349106da325de5e.tar.bz2 | |
Clang: enable -Wbool-conversions and -Wunused-variables on Linux.
-Wbool-conversion warns about EXPECT_EQ(false, blah), so replace
that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah)
for good measure (even though that doesn't generate warnings).
Also remove the one instance of an unused variable.
BUG=69421
TEST=buildbots all compile and all tests pass
Review URL: http://codereview.chromium.org/6300001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/build/common.gypi b/build/common.gypi index 768160a..eb7b370 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -1136,13 +1136,8 @@ }], ['clang==1', { 'cflags': [ - # Don't warn about unused variables, due to a common pattern: - # scoped_deleter unused_variable(&thing_to_delete); - '-Wno-unused-variable', # Clang spots more unused functions. '-Wno-unused-function', - # gtest confuses clang. - '-Wno-bool-conversions', # Don't die on dtoa code that uses a char as an array index. '-Wno-char-subscripts', # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see |