diff options
| author | tc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-28 00:43:27 +0000 |
|---|---|---|
| committer | tc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-28 00:43:27 +0000 |
| commit | 5315f284dc1f36b979dc995df11f0ed8bec258ba (patch) | |
| tree | dee780a290921d3adaa8ece1cac10b5e56866faf /build | |
| parent | 5a2a01231ea0020d6ac425b230c602ed972a5ed6 (diff) | |
| download | chromium_src-5315f284dc1f36b979dc995df11f0ed8bec258ba.zip chromium_src-5315f284dc1f36b979dc995df11f0ed8bec258ba.tar.gz chromium_src-5315f284dc1f36b979dc995df11f0ed8bec258ba.tar.bz2 | |
Take 3 at turning on -Werror. This passed the last run on the
buildbots, except for the valgrind bots which use -O1. For now,
just disable -Werror on the bots with an override.
Review URL: http://codereview.chromium.org/100087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14695 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/build/common.gypi b/build/common.gypi index 49b030d..93e9df9 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -147,6 +147,11 @@ # are compatible with the general 32-bit-ness. '-32', ], + # Enable -Werror by default, but put it in a variable so it can + # be disabled in ~/.gyp/include.gypi on the valgrind builders. + 'variables': { + 'werror%': '-Werror', + }, # All floating-point computations on x87 happens in 80-bit # precision. Because the C and C++ language standards allow # the compiler to keep the floating-point values in higher @@ -180,8 +185,7 @@ '-msse2', '-mfpmath=sse', '-Wall', - # TODO(sgk): when chromium_code targets are clean of warnings. - #'-Werror', + '<(werror)', # See note above about the werror variable. ], 'ldflags': [ '-m32', @@ -258,7 +262,7 @@ 'ldflags': [ '-rdynamic', # Allows backtrace to resolve symbols. ], - }, + }, 'Release': { 'cflags': [ '-O2', |