diff options
| author | tapted@chromium.org <tapted@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-03 03:55:19 +0000 |
|---|---|---|
| committer | tapted@chromium.org <tapted@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-03 03:55:19 +0000 |
| commit | 51b195f89df9949639c88b57d8a1642788a31540 (patch) | |
| tree | 15672b967158bcd73cad20d6a652bfc06056430a /build | |
| parent | a43849ba735dd08f53eead610ade7083e7fc79e4 (diff) | |
| download | chromium_src-51b195f89df9949639c88b57d8a1642788a31540.zip chromium_src-51b195f89df9949639c88b57d8a1642788a31540.tar.gz chromium_src-51b195f89df9949639c88b57d8a1642788a31540.tar.bz2 | |
Refactor views app list services to allow more code sharing
To run the toolkit-views app launcher on Mac, it needs a new app list
service + supporting classes. It's going to look a lot like the Linux
one. This CL starts by sharing what can be shared between Windows and
Linux, in preparation for using it on Mac as well.
It does this principally by:
- Moving `app_list_shower` to `app_list_shower_views`, making it views-specific;
- Adding AppListServiceViews, which Win/Linux (and soon Mac) inherit from;
- Rearranging the delegation to eliminate some boilerplate.
Other changes:
- Removed AppList container abstract interface (now just access AppListView);
- Removed AppListFactory (now AppListShower::MakeViewForCurrentProfile());
- Moved AppListControllerDelegateLinux to AppListControllerDelegateViews;
- Most of AppListServiceLinux moves to AppListServiceViews;
- Added AppListShowerDelegate and AppListShower given virtual method
hooks to assist testability (previously AppListShower was given a NULL
service/delegate in tests);
- Positioning logic in AppListWin/AppListLinux made static/stateless;
- Removes the `on_should_dismiss_` closure (now just dismiss via the service;
- Big trim of AppListServiceWin and AppListServiceLinux - now these are
just platform-specific stuff.
BUG=365977
TEST=Just refactoring, nothing should change
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267184
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267354
Review URL: https://codereview.chromium.org/225053004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268035 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/filename_rules.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/build/filename_rules.gypi b/build/filename_rules.gypi index 001b975..8b49202 100644 --- a/build/filename_rules.gypi +++ b/build/filename_rules.gypi @@ -72,7 +72,7 @@ ], }], ['<(toolkit_views)==0 or >(nacl_untrusted_build)==1', { - 'sources/': [ ['exclude', '_views\\.(h|cc)$'] ] + 'sources/': [ ['exclude', '_views(_browsertest|_unittest)?\\.(h|cc)$'] ] }], ['<(use_aura)==0 or >(nacl_untrusted_build)==1', { 'sources/': [ ['exclude', '_aura(_browsertest|_unittest)?\\.(h|cc)$'], |