diff options
| author | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-06 16:54:40 +0000 |
|---|---|---|
| committer | thestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-06 16:54:40 +0000 |
| commit | 66e6560ac35f03ce51f020024d91acc40c6ce7a2 (patch) | |
| tree | a1a22f8015ed6566123b67d9b323c9229fc09a41 /build | |
| parent | 8b142ed49a29352f3d595b65f329ba0a0fed2064 (diff) | |
| download | chromium_src-66e6560ac35f03ce51f020024d91acc40c6ce7a2.zip chromium_src-66e6560ac35f03ce51f020024d91acc40c6ce7a2.tar.gz chromium_src-66e6560ac35f03ce51f020024d91acc40c6ce7a2.tar.bz2 | |
Linux: simplify dump_app_syms since newer versions of Breakpad no longer generates different signatures for stripped/unstripped binaries.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1627001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43724 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rwxr-xr-x | build/linux/dump_app_syms | 26 |
1 files changed, 6 insertions, 20 deletions
diff --git a/build/linux/dump_app_syms b/build/linux/dump_app_syms index 7043b10..632bcc7 100755 --- a/build/linux/dump_app_syms +++ b/build/linux/dump_app_syms @@ -1,11 +1,11 @@ #!/bin/sh -# Copyright (c) 2009 The Chromium Authors. All rights reserved. +# Copyright (c) 2010 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. # -# Helper script to run dump_syms on Chrome Linux executables and "fixup" the -# generated sigs (due to changes to the binary from stripping). +# Helper script to run dump_syms on Chrome Linux executables and strip +# them if needed. set -e @@ -22,29 +22,15 @@ fi SCRIPTDIR="$(readlink -f "$(dirname "$0")")" DUMPSYMS="$1" -KEEP_STRIPPED_BINARY="$2" +STRIP_BINARY="$2" INFILE="$3" OUTFILE="$4" -STRIPPED=$(mktemp -q -t stripped-XXXXX) -if [ $? -ne 0 ]; then - echo "ERROR: Could not create temp stripped '$INFILE'" >&2 - exit 1 -fi - # Dump the symbols from the given binary. if [ ! -e "$OUTFILE" -o "$INFILE" -nt "$OUTFILE" ]; then "$DUMPSYMS" "$INFILE" > "$OUTFILE" fi -# Strip the binary and calculate the signature of that, since that's what ships. -strip "$INFILE" -o "$STRIPPED" -NEWSIG=$("$SCRIPTDIR/dump_signature.py" "$STRIPPED") -if [ "$KEEP_STRIPPED_BINARY" != "0" ]; then - mv "$STRIPPED" "$INFILE" -else - rm "$STRIPPED" +if [ "$STRIP_BINARY" != "0" ]; then + strip "$INFILE" fi - -# Replace the old signature with the stripped signature in the symbols file. -sed -i "1s/ [0-9A-F]* / $NEWSIG /" "$OUTFILE" |