diff options
| author | andrewhayden@chromium.org <andrewhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-24 15:58:30 +0000 |
|---|---|---|
| committer | andrewhayden@chromium.org <andrewhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-24 15:58:30 +0000 |
| commit | ad502509b522e4f57afcc836ae8a448809f25605 (patch) | |
| tree | 9c88e590cfede46c9926dd9261f4a32bae9d2995 /build | |
| parent | 365c9fd2ebfc8b8f694a41589fe3ce77749afc44 (diff) | |
| download | chromium_src-ad502509b522e4f57afcc836ae8a448809f25605.zip chromium_src-ad502509b522e4f57afcc836ae8a448809f25605.tar.gz chromium_src-ad502509b522e4f57afcc836ae8a448809f25605.tar.bz2 | |
Make it possible to generate static and dynamic CLD2 libraries in one build.
This is necessary to allow building multiple targets with conflicting
requirements, such as chrome_shell (needing a statically-linked CLD2) at the
same time as the APK for Android (using, e.g., the "component" CLD2 data
source). For more information and background, refer to the linked bug.
This change should be a no-op in all current build configurations, but moves
closer to enabling the behavior described above.
BUG=367239
TBR=toyoshim
NOTRY=true
Review URL: https://codereview.chromium.org/416863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285289 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/build/common.gypi b/build/common.gypi index c9d34fa..7be6ee0 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -2764,18 +2764,13 @@ # chrome://translate-internals 'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'], }], - ['cld2_data_source=="static"', { + ['cld_version==2 and cld2_data_source=="static"', { 'defines': ['CLD_DATA_FROM_STATIC'], - }, { - # CLD2 headers use this #define to control the visibility of dynamic - # mode functions. We use these functions, so we must define here for - # our #includes to work right. - 'defines': ['CLD2_DYNAMIC_MODE'], }], - ['cld2_data_source=="standalone"', { + ['cld_version==2 and cld2_data_source=="standalone"', { 'defines': ['CLD_DATA_FROM_STANDALONE'], }], - ['cld2_data_source=="component"', { + ['cld_version==2 and cld2_data_source=="component"', { 'defines': ['CLD_DATA_FROM_COMPONENT'], }], ['enable_printing==1', { |