diff options
| author | sbc@chromium.org <sbc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-08 02:42:50 +0000 |
|---|---|---|
| committer | sbc@chromium.org <sbc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-08 02:42:50 +0000 |
| commit | bbd56bc3b08069d668e608b15685987293dfde82 (patch) | |
| tree | 2034c86cb90913a1b4d271c205228ae07cb2ba1b /build | |
| parent | 92c40ffcf292091c0c20ad761c92730e909decab (diff) | |
| download | chromium_src-bbd56bc3b08069d668e608b15685987293dfde82.zip chromium_src-bbd56bc3b08069d668e608b15685987293dfde82.tar.gz chromium_src-bbd56bc3b08069d668e608b15685987293dfde82.tar.bz2 | |
Update gold linker to 2.23.1
This is the second attempt to integrate latest gold version.
The first time around there were crashes seen on 32-bit linux
hosts. Disabling multi-threaded linking on 32-bit hosts
fixes the issue.
BUG=161942
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11444012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171917 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/build/common.gypi b/build/common.gypi index f24dadde..42e0568 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -2808,14 +2808,19 @@ ], }], ['linux_use_gold_flags==1', { - 'ldflags': [ - # Experimentation found that using four linking threads - # saved ~20% of link time. - # https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/281527606915bb36 - '-Wl,--threads', - '-Wl,--thread-count=4', - ], 'conditions': [ + # Don't enable multi-threaded linking for 32-bit targets as it + # causes intermittent crashed on lucid32: http://crbug.com/161942 + # TODO(sbc): remove this once gold bug is fixed + ['host_arch!="ia32"', { + 'ldflags': [ + # Experimentation found that using four linking threads + # saved ~20% of link time. + # https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/281527606915bb36 + '-Wl,--threads', + '-Wl,--thread-count=4', + ], + }], ['release_valgrind_build==0', { 'target_conditions': [ ['_toolset=="target"', { |