diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-14 18:54:08 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-14 18:54:08 +0000 |
| commit | e296caca00f87cba093c4239e537464e88dbef92 (patch) | |
| tree | d64e7069c5ad689707765958ef6f37fd8454ba38 /build | |
| parent | 54c3e7cfa23776ef091b9a6209d86ef663426431 (diff) | |
| download | chromium_src-e296caca00f87cba093c4239e537464e88dbef92.zip chromium_src-e296caca00f87cba093c4239e537464e88dbef92.tar.gz chromium_src-e296caca00f87cba093c4239e537464e88dbef92.tar.bz2 | |
Move GN's glib_cxx_debug flag onto the debug configuration.
Previously this was in a global config which also applied to the release build.
R=thakis@chromium.org
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/137553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244781 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/config/BUILD.gn | 7 | ||||
| -rw-r--r-- | build/config/compiler/BUILD.gn | 5 |
2 files changed, 7 insertions, 5 deletions
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn index 37572d9..fe60b96 100644 --- a/build/config/BUILD.gn +++ b/build/config/BUILD.gn @@ -43,6 +43,13 @@ config("debug") { "DYNAMIC_ANNOTATIONS_ENABLED=1", "WTF_USE_DYNAMIC_ANNOTATIONS=1", ] + + if (is_linux && !is_android && cpu_arch == "x64") { + # Enable libstdc++ debugging facilities to help catch problems early, see + # http://crbug.com/65151 . + # TODO(phajdan.jr): Should we enable this for all of POSIX? + defines += [ "_GLIBCXX_DEBUG=1" ] + } } config("release") { diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn index ce0aae7..10617cd 100644 --- a/build/config/compiler/BUILD.gn +++ b/build/config/compiler/BUILD.gn @@ -128,11 +128,6 @@ config("compiler") { } if (cpu_arch == "x64") { - # Enable libstdc++ debugging facilities to help catch problems early, see - # http://crbug.com/65151 . - # TODO(phajdan.jr): Should we enable this for all of POSIX? - defines += [ "_GLIBCXX_DEBUG=1" ] - # Use gold for linking on 64-bit Linux only (on 32-bit it runs out of # address space, and it doesn't support cross-compiling). gold_path = rebase_path("//third_party/gold", ".", root_build_dir) |