diff options
| author | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-29 19:52:17 +0000 |
|---|---|---|
| committer | nirnimesh@chromium.org <nirnimesh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-29 19:52:17 +0000 |
| commit | 2c1d273765f1cc433555e68b129f03e8575d3f16 (patch) | |
| tree | e118544e6f4692d8ed3b5fa93f429aa15e9b8442 /build | |
| parent | 596632af439961248cb1f677f0d613531c1a9185 (diff) | |
| download | chromium_src-2c1d273765f1cc433555e68b129f03e8575d3f16.zip chromium_src-2c1d273765f1cc433555e68b129f03e8575d3f16.tar.gz chromium_src-2c1d273765f1cc433555e68b129f03e8575d3f16.tar.bz2 | |
Bisect script should exit gracefully when not enough revisions are present
between the specified good and bad builds.
Also, add usage string for specifying chromium options
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/343029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30494 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rwxr-xr-x | build/build-bisect.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/build/build-bisect.py b/build/build-bisect.py index a04bd11..aeec7b3 100755 --- a/build/build-bisect.py +++ b/build/build-bisect.py @@ -145,7 +145,7 @@ def AskIsGoodBuild(rev): print("Just answer the question...") def main(): - usage = ('%prog [options]\n' + usage = ('%prog [options] [-- chromium-options]\n' 'Perform binary search on the snapshot builds.') parser = optparse.OptionParser(usage=usage) # Strangely, the default help output doesn't include the choice list. @@ -206,6 +206,9 @@ def main(): # Get a list of revisions to bisect across. revlist = GetRevList(good_rev, bad_rev) + if len(revlist) < 2: # Don't have enough builds to bisect + print "We don't have enough builds to bisect. revlist: %s" % revlist + sys.exit(1) # If we don't have a |good_rev|, set it to be the first revision possible. if good_rev == 0: |