diff options
| author | craig.schlenter@chromium.org <craig.schlenter@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-13 19:25:42 +0000 |
|---|---|---|
| committer | craig.schlenter@chromium.org <craig.schlenter@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-13 19:25:42 +0000 |
| commit | ecf52cb820c80a600436aca1a5a72533db32b48d (patch) | |
| tree | 8548e6bda277f73d26833a0f73696885a5a3ca2a /build | |
| parent | 001f484f9e86caca78dfb7f17631746ce8e5dbc0 (diff) | |
| download | chromium_src-ecf52cb820c80a600436aca1a5a72533db32b48d.zip chromium_src-ecf52cb820c80a600436aca1a5a72533db32b48d.tar.gz chromium_src-ecf52cb820c80a600436aca1a5a72533db32b48d.tar.bz2 | |
Use no_strict_aliasing=1 by default.
This will turn on -fno-strict-aliasing. There are regular aliasing problems
in the codebase and at least one of these was not caught by -Wall -Werror
so defaulting to -fno-strict-aliasing seems like a good idea especially
given the increased popularity of gcc 4.4 with it's use in karmic, fedora and in
chromeos chroot builds et. al.
The long term plan is to have some test infrastructure in place that will test
4.4 binaries and to fix the aliasing issues.
BUG=28749
Review URL: http://codereview.chromium.org/519034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36151 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/build/common.gypi b/build/common.gypi index 5b86952..8b79110 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -580,7 +580,13 @@ # Enable -Werror by default, but put it in a variable so it can # be disabled in ~/.gyp/include.gypi on the valgrind builders. 'variables': { - 'no_strict_aliasing%': 0, + # Use -fno-strict-aliasing by default since gcc 4.4 has periodic + # issues that slip through the cracks. We could do this just for + # gcc 4.4 but it makes more sense to be consistent on all + # compilers in use. TODO(Craig): turn this off again when + # there is some 4.4 test infrastructure in place and existing + # aliasing issues have been fixed. + 'no_strict_aliasing%': 1, 'conditions': [['OS=="linux"', {'werror%': '-Werror',}], ['OS=="freebsd"', {'werror%': '',}], ['OS=="openbsd"', {'werror%': '',}], |