diff options
| author | mnaganov@chromium.org <mnaganov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-04 22:55:43 +0000 |
|---|---|---|
| committer | mnaganov@chromium.org <mnaganov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-04 22:55:43 +0000 |
| commit | 2908f2cef8990d5c01dfc1d871df56cd1fae2ce4 (patch) | |
| tree | 7aa820c0732b1f3112b0c5c0c71d3e43219d632e /build | |
| parent | 383ca80a4d2389c328044d5c98162101b80dd297 (diff) | |
| download | chromium_src-2908f2cef8990d5c01dfc1d871df56cd1fae2ce4.zip chromium_src-2908f2cef8990d5c01dfc1d871df56cd1fae2ce4.tar.gz chromium_src-2908f2cef8990d5c01dfc1d871df56cd1fae2ce4.tar.bz2 | |
[Android] Implement WebSettings.setAppCache{Enabled|Path}
AppCacheEnabled is mapped onto WebPreferences.application_cache_enabled, which goes directly into WebKit Settings.
AppCachePath is only used as a flag to enable AppCache. We can't make use of the full path given, because in Chromium the Application Cache directory lives inside the browser context (profile).
The tests added trigger a DCHECK in disk cache, unless the profile is empty when the test starts. This makes impossible to run them both now, so only one of them is enabled for now.
Android CTS tests WebSettings.testAppCache{Disabled|Enabled} are passing with this patch.
Review URL: https://chromiumcodereview.appspot.com/11411229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171074 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/android/findbugs_filter/findbugs_known_bugs.txt | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt b/build/android/findbugs_filter/findbugs_known_bugs.txt index a61d6df..7592afb 100644 --- a/build/android/findbugs_filter/findbugs_known_bugs.txt +++ b/build/android/findbugs_filter/findbugs_known_bugs.txt @@ -73,7 +73,6 @@ M D DLS: Dead store to testUrl in org.chromium.android_webview.test.ClientOnPage M D DLS: Dead store to time in org.chromium.net.test.util.TestWebServer.setDateHeaders(HttpResponse) At TestWebServer.java M D DMI: Hard coded reference to an absolute pathname in org.chromium.android_webview.test.ArchiveTest.testAutoBadPath() At ArchiveTest.java M D DMI: Hard coded reference to an absolute pathname in org.chromium.android_webview.test.ArchiveTest.testExplicitBadPath() At ArchiveTest.java -M D ICAST: Result of integer multiplication cast to long in org.chromium.android_webview.test.AwSettingsTest.testBlockNetworkImagesBlocksNetworkImageAndReloadInPlace() At AwSettingsTest.java M D ICAST: integral division result cast to double or float in org.chromium.content.browser.HandleView.setOrientation(int) At HandleView.java M D REC: Exception is caught when Exception is not thrown in org.chromium.content.browser.test.util.UiUtils.findParentViewForIdAcrossActivities(int) At UiUtils.java M D SF: Switch statement found in org.chromium.chrome.browser.ChromeBrowserProvider.insert(Uri, ContentValues) where one case falls through to the next case At ChromeBrowserProvider.java @@ -141,3 +140,4 @@ M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_INHERIT should be M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE should be package protected In LoadUrlParams.java M C RCN: Nullcheck of GestureDetector.mVelocityTracker at line 630 of value previously dereferenced in org.chromium.content.browser.third_party.GestureDetector.onTouchEvent(MotionEvent) At GestureDetector.java M D SF: Switch statement found in org.chromium.content.browser.third_party.GestureDetector.onTouchEvent(MotionEvent) where default case is missing At GestureDetector.java +M D ST: Write to static field org.chromium.content.browser.ContentSettings.sAppCachePathIsSet from instance method org.chromium.content.browser.ContentSettings.setAppCachePath(String) At ContentSettings.java |