diff options
| author | michaelbai@chromium.org <michaelbai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-21 02:27:51 +0000 |
|---|---|---|
| committer | michaelbai@chromium.org <michaelbai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-21 02:27:51 +0000 |
| commit | 8157ea92c786de0be914a8f685c3a46576056a0e (patch) | |
| tree | fef6b2d947bd193c815f9bddb054f07e44d666ae /build | |
| parent | 07b957beff99920699dd32d53d2fe7e7596a475f (diff) | |
| download | chromium_src-8157ea92c786de0be914a8f685c3a46576056a0e.zip chromium_src-8157ea92c786de0be914a8f685c3a46576056a0e.tar.gz chromium_src-8157ea92c786de0be914a8f685c3a46576056a0e.tar.bz2 | |
Upstream the CL to remove the target_arch x86
BUG=125329
Review URL: https://chromiumcodereview.appspot.com/10956019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157897 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 33 |
1 files changed, 15 insertions, 18 deletions
diff --git a/build/common.gypi b/build/common.gypi index e3dee35..a6ba880 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -989,28 +989,30 @@ # Location of Android NDK. 'variables': { 'variables': { - 'android_ndk_root%': '<!(/bin/echo -n $ANDROID_NDK_ROOT)', - # Android uses x86 instead of ia32 for their target_arch - # designation. - # TODO(wistoch): Adjust the target_arch naming scheme to avoid - # confusion. - # http://crbug.com/125329 + 'variables': { + 'android_ndk_root%': '<!(/bin/echo -n $ANDROID_NDK_ROOT)', + }, + 'android_ndk_root%': '<(android_ndk_root)', 'conditions': [ ['target_arch == "ia32"', { - 'target_arch': 'x86', 'android_app_abi%': 'x86', + 'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-9/arch-x86', }], - ['target_arch=="arm" and armv7==0', { - 'android_app_abi%': 'armeabi', - }], - ['target_arch=="arm" and armv7==1', { - 'android_app_abi%': 'armeabi-v7a', + ['target_arch=="arm"', { + 'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-9/arch-arm', + 'conditions': [ + ['armv7==0', { + 'android_app_abi%': 'armeabi', + }, { + 'android_app_abi%': 'armeabi-v7a', + }], + ], }], ], }, 'android_ndk_root%': '<(android_ndk_root)', - 'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-9/arch-<(target_arch)', 'android_app_abi%': '<(android_app_abi)', + 'android_ndk_sysroot%': '<(android_ndk_sysroot)', }, 'android_ndk_root%': '<(android_ndk_root)', 'android_ndk_sysroot': '<(android_ndk_sysroot)', @@ -2581,7 +2583,6 @@ # Android-specific options; note that most are set above with Linux. ['OS=="android"', { 'variables': { - 'target_arch%': 'arm', # target_arch in android terms. # This is the id for the archived chrome symbols. Each build that # archives symbols is assigned an id which is then added to GYP_DEFINES. # This is written to the device log on crashes just prior to dropping a @@ -2589,10 +2590,6 @@ # from the id. 'chrome_symbols_id%': '', 'conditions': [ - # Android uses x86 instead of ia32 for their target_arch designation. - ['target_arch=="ia32"', { - 'target_arch%': 'x86', - }], # Use shared stlport library when system one used. # Figure this out early since it needs symbols from libgcc.a, so it # has to be before that in the set of libraries. |