diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-13 22:39:52 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-13 22:39:52 +0000 |
commit | 31d18e07e69c8ceb80e31daa7d12e188ecad63fa (patch) | |
tree | 7f845913d099782fd3cade15f2224ef8001983ce /build | |
parent | 80da086459603c74e621b606eb71f1a4fc1ea0ff (diff) | |
download | chromium_src-31d18e07e69c8ceb80e31daa7d12e188ecad63fa.zip chromium_src-31d18e07e69c8ceb80e31daa7d12e188ecad63fa.tar.gz chromium_src-31d18e07e69c8ceb80e31daa7d12e188ecad63fa.tar.bz2 |
Cleanup in preparation for Fullscreen mode.
* Remove some unnecessary cruft from BrowserView.
* Change Find bar to position itself based on the translated bounds of the bookmark bar or toolbar, whichever is found. This is a bit simpler than the offset-based version before and works much better with Fullscreen mode.
* Make Bookmark bar not have a strange "1 px" minimum size, which was only needed because we were always subtracting that much in the BrowserView layout functions.
* Change BrowserView toolbar layout functions to always lay out toolbars (instead of only when visible; they are 0-height when invisible), and explicitly set their visibility. This shouldn't have any visible effect, but it goes hand-in-hand with the Find bar changes.
* Add a function on the Bookmark bar to determine if we're displaying detached, and change various callers to use it. Right now this does fairly little, but in Fullscreen mode it becomes necessary because we always display the Bookmark bar this way. There is one user-visible effect: when toggling the Bookmark bar on/off while the Find bar is visible, the Find bar will now snap to the Bookmark bar only when it finishes "attaching" to the toolbar, not as soon as it starts. Finnur and I both think this actually looks slightly better.
Review URL: http://codereview.chromium.org/21359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9799 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
0 files changed, 0 insertions, 0 deletions