diff options
| author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-15 00:45:07 +0000 |
|---|---|---|
| committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-15 00:45:07 +0000 |
| commit | 7d389e235c5afa2861d8503a5df517206818a4e5 (patch) | |
| tree | e5a6838c0d377ffad90f726bb04758ed9c501d3f /build | |
| parent | 97746f96aae458638e6a61200e1dd66ffad06e53 (diff) | |
| download | chromium_src-7d389e235c5afa2861d8503a5df517206818a4e5.zip chromium_src-7d389e235c5afa2861d8503a5df517206818a4e5.tar.gz chromium_src-7d389e235c5afa2861d8503a5df517206818a4e5.tar.bz2 | |
Enable Clang warnings for implementation files on all platforms.
This fixes a few remaining issues for Android builds
BUG=115047
Review URL: https://chromiumcodereview.appspot.com/14876034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200125 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build')
| -rw-r--r-- | build/common.gypi | 23 |
1 files changed, 2 insertions, 21 deletions
diff --git a/build/common.gypi b/build/common.gypi index 707c433..0334416 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -1542,27 +1542,8 @@ 'grit_defines': ['-D', 'use_concatenated_impulse_responses'], }], ['clang_use_chrome_plugins==1 and OS!="win"', { - 'variables': { - 'clang_chrome_plugins_flags': [ - '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)' - ], - }, - 'conditions': [ - ['OS=="linux" or OS=="mac"', { - 'clang_chrome_plugins_flags': [ - '<@(clang_chrome_plugins_flags)' - ], - }, { - # TODO(rsleevi): http://crbug.com/115047 - This warning is only - # enabled for Linux for now. Disable everywhere else. - 'clang_chrome_plugins_flags': [ - '<@(clang_chrome_plugins_flags)', - '-Xclang', - '-plugin-arg-find-bad-constructs', - '-Xclang', - 'skip-virtuals-in-implementations', - ], - }] + 'clang_chrome_plugins_flags': [ + '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)' ], }], |