diff options
| author | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-05 16:56:49 +0000 |
|---|---|---|
| committer | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-05 16:56:49 +0000 |
| commit | ec454716d4056ddc796788b0cab45ec99b16113b (patch) | |
| tree | c12de89ddf61012d1d5eb7f8c8573773a9215f5a /cc/DEPS | |
| parent | 992359d7cb13821cbc9cbf76d3e870860dea760d (diff) | |
| download | chromium_src-ec454716d4056ddc796788b0cab45ec99b16113b.zip chromium_src-ec454716d4056ddc796788b0cab45ec99b16113b.tar.gz chromium_src-ec454716d4056ddc796788b0cab45ec99b16113b.tar.bz2 | |
cc: Remove all remaining use of WebCore Rect/Point/Size types from the compositor.
This change removes all IntPoint/FloatRect/IntSize/etc from the compositor.
There remains an indirect dependency on these types through the
WebCore::Region class, which we wrap but need to replace. However, the wrapper
there hides the WebCore types inside it, so there are now no references to the
types from anywhere else in the compositor.
I went back and forth on how to deal with scroll "positions". The name suggested
that they should be Points, and that the deltas should be Vectors. However this
lent itself to super awkward math at times. In the end, it was much cleaner to
make all scroll "positions" into scroll "offsets" and represent everything as
Vectors.
Covered by existing tests; no change in behaviour.
R=enne
BUG=147395
Review URL: https://codereview.chromium.org/11367080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165947 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/DEPS')
| -rw-r--r-- | cc/DEPS | 17 |
1 files changed, 1 insertions, 16 deletions
@@ -5,22 +5,7 @@ include_rules = [ "+third_party/khronos/GLES2/gl2ext.h", "+ui/gfx", "+media", -# http://crbug.com/144542 - "+third_party/WebKit/Source/WebCore/platform/graphics/FloatPoint.h", - "+third_party/WebKit/Source/WebCore/platform/graphics/FloatQuad.h", - "+third_party/WebKit/Source/WebCore/platform/graphics/FloatRect.h", - "+third_party/WebKit/Source/WebCore/platform/graphics/FloatSize.h", - "+third_party/WebKit/Source/WebCore/platform/graphics/IntPoint.h", - "+third_party/WebKit/Source/WebCore/platform/graphics/IntRect.h", - "+third_party/WebKit/Source/WebCore/platform/graphics/IntSize.h", - "+Source/WebCore/platform/graphics/FloatPoint.h", - "+Source/WebCore/platform/graphics/FloatQuad.h", - "+Source/WebCore/platform/graphics/FloatRect.h", - "+Source/WebCore/platform/graphics/FloatSize.h", - "+Source/WebCore/platform/graphics/IntPoint.h", - "+Source/WebCore/platform/graphics/IntRect.h", - "+Source/WebCore/platform/graphics/IntSize.h", -# http://crbug.com/144540 +# http://crbug.com/147395 "+third_party/WebKit/Source/WebCore/platform/graphics/Region.h", "+Source/WebCore/platform/graphics/Region.h", # TODO(jamesr): Resolve these |