diff options
| author | enne@chromium.org <enne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-26 20:21:59 +0000 |
|---|---|---|
| committer | enne@chromium.org <enne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-26 20:21:59 +0000 |
| commit | 6dc0b6f1049427372a5201ccf41e076a959a2622 (patch) | |
| tree | 6c9326abc2dae31223814331ac18b0600367bef7 /cc/PRESUBMIT.py | |
| parent | a6ee73196b7c0df512a196fd4416817bbd25ffeb (diff) | |
| download | chromium_src-6dc0b6f1049427372a5201ccf41e076a959a2622.zip chromium_src-6dc0b6f1049427372a5201ccf41e076a959a2622.tar.gz chromium_src-6dc0b6f1049427372a5201ccf41e076a959a2622.tar.bz2 | |
cc: Add FIXME presubmit warning
R=danakj@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/17904003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208772 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/PRESUBMIT.py')
| -rw-r--r-- | cc/PRESUBMIT.py | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py index e133e9a..3f1912b 100644 --- a/cc/PRESUBMIT.py +++ b/cc/PRESUBMIT.py @@ -121,12 +121,29 @@ def CheckPassByValue(input_api, (f.LocalPath(), match.group('type')))) return local_errors +def CheckTodos(input_api, output_api): + errors = [] + + source_file_filter = lambda x: x + for f in input_api.AffectedSourceFiles(source_file_filter): + contents = input_api.ReadFile(f, 'rb') + if ('FIX'+'ME') in contents or re.search(r"TO(?:)DO[^(]", contents): + errors.append(f.LocalPath()) + + if errors: + return [output_api.PresubmitError( + 'All TO'+'DO comments should be of the form TODO(name).', + items=errors)] + return [] + + def CheckChangeOnUpload(input_api, output_api): results = [] results += CheckAsserts(input_api, output_api) results += CheckSpamLogging(input_api, output_api, black_list=CC_PERF_TEST) results += CheckPassByValue(input_api, output_api) results += CheckChangeLintsClean(input_api, output_api) + results += CheckTodos(input_api, output_api) return results def GetPreferredTrySlaves(project, change): |