diff options
author | weiliangc@chromium.org <weiliangc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-03 18:54:34 +0000 |
---|---|---|
committer | weiliangc@chromium.org <weiliangc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-03 18:54:34 +0000 |
commit | f7030c34dd9efa5710b503d88e37b7e848a436ce (patch) | |
tree | 1482a8105f389ae2244b2c03f25d3dd55b2b2adc /cc/layers/delegated_renderer_layer_impl.cc | |
parent | 405cb61dc2d5b8969b69d005e57873a239e5d89c (diff) | |
download | chromium_src-f7030c34dd9efa5710b503d88e37b7e848a436ce.zip chromium_src-f7030c34dd9efa5710b503d88e37b7e848a436ce.tar.gz chromium_src-f7030c34dd9efa5710b503d88e37b7e848a436ce.tar.bz2 |
Create DrawQuad in RenderPass and only give out raw pointer to layers
Instead of each layer calling Create function on DrawQuad and pass
ownership around, create DrawQuad in RenderPass and only pass the raw
pointer to layers.
BUG=344962
TEST=cc_unittests
Review URL: https://codereview.chromium.org/369623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281306 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/layers/delegated_renderer_layer_impl.cc')
-rw-r--r-- | cc/layers/delegated_renderer_layer_impl.cc | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/cc/layers/delegated_renderer_layer_impl.cc b/cc/layers/delegated_renderer_layer_impl.cc index 30a7b01..e110ff7 100644 --- a/cc/layers/delegated_renderer_layer_impl.cc +++ b/cc/layers/delegated_renderer_layer_impl.cc @@ -354,32 +354,32 @@ void DelegatedRendererLayerImpl::AppendRainbowDebugBorder( break; if (!top.IsEmpty()) { - scoped_ptr<SolidColorDrawQuad> top_quad = SolidColorDrawQuad::Create(); + SolidColorDrawQuad* top_quad = + render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); top_quad->SetNew( shared_quad_state, top, top, colors[i % kNumColors], false); - render_pass->AppendDrawQuad(top_quad.PassAs<DrawQuad>()); - scoped_ptr<SolidColorDrawQuad> bottom_quad = SolidColorDrawQuad::Create(); + SolidColorDrawQuad* bottom_quad = + render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); bottom_quad->SetNew(shared_quad_state, bottom, bottom, colors[kNumColors - 1 - (i % kNumColors)], false); - render_pass->AppendDrawQuad(bottom_quad.PassAs<DrawQuad>()); } if (!left.IsEmpty()) { - scoped_ptr<SolidColorDrawQuad> left_quad = SolidColorDrawQuad::Create(); + SolidColorDrawQuad* left_quad = + render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); left_quad->SetNew(shared_quad_state, left, left, colors[kNumColors - 1 - (i % kNumColors)], false); - render_pass->AppendDrawQuad(left_quad.PassAs<DrawQuad>()); - scoped_ptr<SolidColorDrawQuad> right_quad = SolidColorDrawQuad::Create(); + SolidColorDrawQuad* right_quad = + render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); right_quad->SetNew( shared_quad_state, right, right, colors[i % kNumColors], false); - render_pass->AppendDrawQuad(right_quad.PassAs<DrawQuad>()); } } } @@ -468,7 +468,7 @@ void DelegatedRendererLayerImpl::AppendRenderPassQuads( } if (output_quad) - render_pass->AppendDrawQuad(output_quad.Pass()); + render_pass->quad_list.push_back(output_quad.Pass()); } } |