diff options
| author | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
|---|---|---|
| committer | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
| commit | 0023fc78d056556b353ee17f03760bec8c1fee49 (patch) | |
| tree | 009367358a1c44b08f3142f63b087d936206ba44 /cc/layers/picture_layer_impl.h | |
| parent | 37df32bd517577ac6ad20c6d76b236265caeacaf (diff) | |
| download | chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.zip chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.gz chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.bz2 | |
Pass gfx::Rect and gfx::RectF by const ref.
Avoid unneccessary copy of structures gfx::Rect & gfx::RectF
by passing them by const ref rather than value.
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.
Pass by value creates unneccessary overhead which should be avoided.
BUG=159273
Review URL: https://codereview.chromium.org/93663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/layers/picture_layer_impl.h')
| -rw-r--r-- | cc/layers/picture_layer_impl.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/cc/layers/picture_layer_impl.h b/cc/layers/picture_layer_impl.h index f9ac16d..4b9e3ac 100644 --- a/cc/layers/picture_layer_impl.h +++ b/cc/layers/picture_layer_impl.h @@ -53,8 +53,9 @@ class CC_EXPORT PictureLayerImpl virtual skia::RefPtr<SkPicture> GetPicture() OVERRIDE; // PictureLayerTilingClient overrides. - virtual scoped_refptr<Tile> CreateTile(PictureLayerTiling* tiling, - gfx::Rect content_rect) OVERRIDE; + virtual scoped_refptr<Tile> CreateTile( + PictureLayerTiling* tiling, + const gfx::Rect& content_rect) OVERRIDE; virtual void UpdatePile(Tile* tile) OVERRIDE; virtual gfx::Size CalculateTileSize( gfx::Size content_bounds) const OVERRIDE; @@ -100,7 +101,7 @@ class CC_EXPORT PictureLayerImpl PictureLayerTiling* tiling, const PictureLayerTiling* optional_twin_tiling, float contents_scale, - gfx::Rect rect, + const gfx::Rect& rect, const Region& missing_region) const; void DoPostCommitInitializationIfNeeded() { |