summaryrefslogtreecommitdiffstats
path: root/cc/layers
diff options
context:
space:
mode:
authorboliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-14 02:25:50 +0000
committerboliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-14 02:25:50 +0000
commit9db244686ca531e7debf898089ee03b9b887e96b (patch)
treea80fb06f60797a176ce9dcce0ba71d5751748759 /cc/layers
parent713f36345eb54a4cacacc8839370693b8bdae677 (diff)
downloadchromium_src-9db244686ca531e7debf898089ee03b9b887e96b.zip
chromium_src-9db244686ca531e7debf898089ee03b9b887e96b.tar.gz
chromium_src-9db244686ca531e7debf898089ee03b9b887e96b.tar.bz2
cc: Rename LayerImpl::DidLoseOutputSurface to ReleaseResources
For Android Webview using deferred gl initialization, calling this method does not indicate an error and does not necessarily mean the OutputSurface is lost. Purely mechanical change. BUG= Review URL: https://codereview.chromium.org/132683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244636 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/layers')
-rw-r--r--cc/layers/delegated_renderer_layer_impl.cc2
-rw-r--r--cc/layers/delegated_renderer_layer_impl.h2
-rw-r--r--cc/layers/heads_up_display_layer_impl.cc2
-rw-r--r--cc/layers/heads_up_display_layer_impl.h2
-rw-r--r--cc/layers/heads_up_display_layer_impl_unittest.cc2
-rw-r--r--cc/layers/io_surface_layer_impl.cc2
-rw-r--r--cc/layers/io_surface_layer_impl.h2
-rw-r--r--cc/layers/layer_impl.cc2
-rw-r--r--cc/layers/layer_impl.h7
-rw-r--r--cc/layers/picture_layer_impl.cc2
-rw-r--r--cc/layers/picture_layer_impl.h2
-rw-r--r--cc/layers/picture_layer_impl_unittest.cc16
-rw-r--r--cc/layers/texture_layer_impl.cc2
-rw-r--r--cc/layers/texture_layer_impl.h2
-rw-r--r--cc/layers/tiled_layer_impl.cc2
-rw-r--r--cc/layers/tiled_layer_impl.h2
-rw-r--r--cc/layers/video_layer_impl.cc2
-rw-r--r--cc/layers/video_layer_impl.h2
18 files changed, 27 insertions, 28 deletions
diff --git a/cc/layers/delegated_renderer_layer_impl.cc b/cc/layers/delegated_renderer_layer_impl.cc
index 4b9d90f..2596ec2 100644
--- a/cc/layers/delegated_renderer_layer_impl.cc
+++ b/cc/layers/delegated_renderer_layer_impl.cc
@@ -191,7 +191,7 @@ scoped_ptr<LayerImpl> DelegatedRendererLayerImpl::CreateLayerImpl(
tree_impl, id()).PassAs<LayerImpl>();
}
-void DelegatedRendererLayerImpl::DidLoseOutputSurface() {
+void DelegatedRendererLayerImpl::ReleaseResources() {
ClearRenderPasses();
ClearChildId();
}
diff --git a/cc/layers/delegated_renderer_layer_impl.h b/cc/layers/delegated_renderer_layer_impl.h
index a25b160..a82a1f7 100644
--- a/cc/layers/delegated_renderer_layer_impl.h
+++ b/cc/layers/delegated_renderer_layer_impl.h
@@ -31,7 +31,7 @@ class CC_EXPORT DelegatedRendererLayerImpl : public LayerImpl {
virtual RenderPass::Id FirstContributingRenderPassId() const OVERRIDE;
virtual RenderPass::Id NextContributingRenderPassId(
RenderPass::Id previous) const OVERRIDE;
- virtual void DidLoseOutputSurface() OVERRIDE;
+ virtual void ReleaseResources() OVERRIDE;
virtual bool WillDraw(DrawMode draw_mode,
ResourceProvider* resource_provider) OVERRIDE;
virtual void AppendQuads(QuadSink* quad_sink,
diff --git a/cc/layers/heads_up_display_layer_impl.cc b/cc/layers/heads_up_display_layer_impl.cc
index da47840..304397e 100644
--- a/cc/layers/heads_up_display_layer_impl.cc
+++ b/cc/layers/heads_up_display_layer_impl.cc
@@ -180,7 +180,7 @@ void HeadsUpDisplayLayerImpl::UpdateHudTexture(
gfx::Vector2d());
}
-void HeadsUpDisplayLayerImpl::DidLoseOutputSurface() { hud_resource_.reset(); }
+void HeadsUpDisplayLayerImpl::ReleaseResources() { hud_resource_.reset(); }
bool HeadsUpDisplayLayerImpl::LayerIsAlwaysDamaged() const { return true; }
diff --git a/cc/layers/heads_up_display_layer_impl.h b/cc/layers/heads_up_display_layer_impl.h
index fa38f15..1bcb76f 100644
--- a/cc/layers/heads_up_display_layer_impl.h
+++ b/cc/layers/heads_up_display_layer_impl.h
@@ -43,7 +43,7 @@ class CC_EXPORT HeadsUpDisplayLayerImpl : public LayerImpl {
void UpdateHudTexture(DrawMode draw_mode,
ResourceProvider* resource_provider);
- virtual void DidLoseOutputSurface() OVERRIDE;
+ virtual void ReleaseResources() OVERRIDE;
virtual bool LayerIsAlwaysDamaged() const OVERRIDE;
diff --git a/cc/layers/heads_up_display_layer_impl_unittest.cc b/cc/layers/heads_up_display_layer_impl_unittest.cc
index 5afc019..d0ef774 100644
--- a/cc/layers/heads_up_display_layer_impl_unittest.cc
+++ b/cc/layers/heads_up_display_layer_impl_unittest.cc
@@ -43,7 +43,7 @@ TEST(HeadsUpDisplayLayerImplTest, ResourcelessSoftwareDrawAfterResourceLoss) {
layer.get(), host_impl.resource_provider(), DRAW_MODE_HARDWARE);
// Simulate a resource loss on transitioning to resourceless software mode.
- layer->DidLoseOutputSurface();
+ layer->ReleaseResources();
// Should skip resourceless software draw and not crash in UpdateHudTexture.
CheckDrawLayer(layer.get(),
diff --git a/cc/layers/io_surface_layer_impl.cc b/cc/layers/io_surface_layer_impl.cc
index a70006a..d2c5438 100644
--- a/cc/layers/io_surface_layer_impl.cc
+++ b/cc/layers/io_surface_layer_impl.cc
@@ -123,7 +123,7 @@ void IOSurfaceLayerImpl::AppendQuads(QuadSink* quad_sink,
quad_sink->Append(quad.PassAs<DrawQuad>(), append_quads_data);
}
-void IOSurfaceLayerImpl::DidLoseOutputSurface() {
+void IOSurfaceLayerImpl::ReleaseResources() {
// We don't have a valid texture ID in the new context; however,
// the IOSurface is still valid.
DestroyTexture();
diff --git a/cc/layers/io_surface_layer_impl.h b/cc/layers/io_surface_layer_impl.h
index 356f5f2..5c096bb 100644
--- a/cc/layers/io_surface_layer_impl.h
+++ b/cc/layers/io_surface_layer_impl.h
@@ -32,7 +32,7 @@ class CC_EXPORT IOSurfaceLayerImpl : public LayerImpl {
virtual bool WillDraw(DrawMode draw_mode,
ResourceProvider* resource_provider) OVERRIDE;
- virtual void DidLoseOutputSurface() OVERRIDE;
+ virtual void ReleaseResources() OVERRIDE;
private:
IOSurfaceLayerImpl(LayerTreeImpl* tree_impl, int id);
diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc
index 74a9b84..d434391 100644
--- a/cc/layers/layer_impl.cc
+++ b/cc/layers/layer_impl.cc
@@ -1123,7 +1123,7 @@ Region LayerImpl::VisibleContentOpaqueRegion() const {
void LayerImpl::DidBeginTracing() {}
-void LayerImpl::DidLoseOutputSurface() {}
+void LayerImpl::ReleaseResources() {}
void LayerImpl::SetMaxScrollOffset(gfx::Vector2d max_scroll_offset) {
if (max_scroll_offset_ == max_scroll_offset)
diff --git a/cc/layers/layer_impl.h b/cc/layers/layer_impl.h
index d124457..c796cf3 100644
--- a/cc/layers/layer_impl.h
+++ b/cc/layers/layer_impl.h
@@ -474,10 +474,9 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
virtual void DidBeginTracing();
- // Indicates that the surface previously used to render this layer
- // was lost and that a new one has been created. Won't be called
- // until the new surface has been created successfully.
- virtual void DidLoseOutputSurface();
+ // Release resources held by this layer. Called when the output surface
+ // that rendered this layer was lost or a rendering mode switch has occured.
+ virtual void ReleaseResources();
ScrollbarAnimationController* scrollbar_animation_controller() const {
return scrollbar_animation_controller_.get();
diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc
index 6070bf1..df5ca68 100644
--- a/cc/layers/picture_layer_impl.cc
+++ b/cc/layers/picture_layer_impl.cc
@@ -380,7 +380,7 @@ void PictureLayerImpl::DidBeginTracing() {
pile_->DidBeginTracing();
}
-void PictureLayerImpl::DidLoseOutputSurface() {
+void PictureLayerImpl::ReleaseResources() {
if (tilings_)
RemoveAllTilings();
diff --git a/cc/layers/picture_layer_impl.h b/cc/layers/picture_layer_impl.h
index 2b54d8a..0491efb 100644
--- a/cc/layers/picture_layer_impl.h
+++ b/cc/layers/picture_layer_impl.h
@@ -42,7 +42,7 @@ class CC_EXPORT PictureLayerImpl
virtual void UpdateTilePriorities() OVERRIDE;
virtual void DidBecomeActive() OVERRIDE;
virtual void DidBeginTracing() OVERRIDE;
- virtual void DidLoseOutputSurface() OVERRIDE;
+ virtual void ReleaseResources() OVERRIDE;
virtual void CalculateContentsScale(float ideal_contents_scale,
float device_scale_factor,
float page_scale_factor,
diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc
index 8d2956d..e2bbfbe 100644
--- a/cc/layers/picture_layer_impl_unittest.cc
+++ b/cc/layers/picture_layer_impl_unittest.cc
@@ -164,8 +164,8 @@ class PictureLayerImplTest : public testing::Test {
}
void ResetTilingsAndRasterScales() {
- pending_layer_->DidLoseOutputSurface();
- active_layer_->DidLoseOutputSurface();
+ pending_layer_->ReleaseResources();
+ active_layer_->ReleaseResources();
}
void AssertAllTilesRequired(PictureLayerTiling* tiling) {
@@ -992,7 +992,7 @@ TEST_F(PictureLayerImplTest, DontAddLowResForSmallLayers) {
EXPECT_BOTH_EQ(num_tilings(), 1u);
}
-TEST_F(PictureLayerImplTest, DidLoseOutputSurface) {
+TEST_F(PictureLayerImplTest, ReleaseResources) {
gfx::Size tile_size(400, 400);
gfx::Size layer_bounds(1300, 1900);
@@ -1017,9 +1017,9 @@ TEST_F(PictureLayerImplTest, DidLoseOutputSurface) {
EXPECT_EQ(2u, pending_layer_->tilings()->num_tilings());
// All tilings should be removed when losing output surface.
- active_layer_->DidLoseOutputSurface();
+ active_layer_->ReleaseResources();
EXPECT_EQ(0u, active_layer_->tilings()->num_tilings());
- pending_layer_->DidLoseOutputSurface();
+ pending_layer_->ReleaseResources();
EXPECT_EQ(0u, pending_layer_->tilings()->num_tilings());
// This should create new tilings.
@@ -1063,7 +1063,7 @@ TEST_F(PictureLayerImplTest, ClampTilesToToMaxTileSize) {
EXPECT_EQ(gfx::Size(256, 256).ToString(),
tile->content_rect().size().ToString());
- pending_layer_->DidLoseOutputSurface();
+ pending_layer_->ReleaseResources();
// Change the max texture size on the output surface context.
scoped_ptr<TestWebGraphicsContext3D> context =
@@ -1115,7 +1115,7 @@ TEST_F(PictureLayerImplTest, ClampSingleTileToToMaxTileSize) {
PictureLayerTiling* high_res_tiling = pending_layer_->tilings()->tiling_at(0);
EXPECT_EQ(1u, high_res_tiling->AllTilesForTesting().size());
- pending_layer_->DidLoseOutputSurface();
+ pending_layer_->ReleaseResources();
// Change the max texture size on the output surface context.
scoped_ptr<TestWebGraphicsContext3D> context =
@@ -1394,7 +1394,7 @@ TEST_F(PictureLayerImplTest, SyncTilingAfterReleaseResource) {
// context loss, and later becomes opaque, causing active layer SyncTiling to
// be called.
const float tile_scale = 2.f;
- active_layer_->DidLoseOutputSurface();
+ active_layer_->ReleaseResources();
EXPECT_FALSE(active_layer_->tilings()->TilingAtScale(tile_scale));
pending_layer_->AddTiling(2.f);
EXPECT_TRUE(active_layer_->tilings()->TilingAtScale(tile_scale));
diff --git a/cc/layers/texture_layer_impl.cc b/cc/layers/texture_layer_impl.cc
index 96b44c7..6aa02a6 100644
--- a/cc/layers/texture_layer_impl.cc
+++ b/cc/layers/texture_layer_impl.cc
@@ -209,7 +209,7 @@ Region TextureLayerImpl::VisibleContentOpaqueRegion() const {
return Region();
}
-void TextureLayerImpl::DidLoseOutputSurface() {
+void TextureLayerImpl::ReleaseResources() {
if (external_texture_resource_ && !uses_mailbox_) {
ResourceProvider* resource_provider =
layer_tree_impl()->resource_provider();
diff --git a/cc/layers/texture_layer_impl.h b/cc/layers/texture_layer_impl.h
index c20d960..26dd385 100644
--- a/cc/layers/texture_layer_impl.h
+++ b/cc/layers/texture_layer_impl.h
@@ -34,7 +34,7 @@ class CC_EXPORT TextureLayerImpl : public LayerImpl {
AppendQuadsData* append_quads_data) OVERRIDE;
virtual void DidDraw(ResourceProvider* resource_provider) OVERRIDE;
virtual Region VisibleContentOpaqueRegion() const OVERRIDE;
- virtual void DidLoseOutputSurface() OVERRIDE;
+ virtual void ReleaseResources() OVERRIDE;
unsigned texture_id() const { return texture_id_; }
void set_texture_id(unsigned id) { texture_id_ = id; }
diff --git a/cc/layers/tiled_layer_impl.cc b/cc/layers/tiled_layer_impl.cc
index 765ec05..aea4567 100644
--- a/cc/layers/tiled_layer_impl.cc
+++ b/cc/layers/tiled_layer_impl.cc
@@ -290,7 +290,7 @@ Region TiledLayerImpl::VisibleContentOpaqueRegion() const {
return tiler_->OpaqueRegionInContentRect(visible_content_rect());
}
-void TiledLayerImpl::DidLoseOutputSurface() {
+void TiledLayerImpl::ReleaseResources() {
tiler_->reset();
}
diff --git a/cc/layers/tiled_layer_impl.h b/cc/layers/tiled_layer_impl.h
index f704823..f4ed1e8 100644
--- a/cc/layers/tiled_layer_impl.h
+++ b/cc/layers/tiled_layer_impl.h
@@ -43,7 +43,7 @@ class CC_EXPORT TiledLayerImpl : public LayerImpl {
void PushInvalidTile(int i, int j);
virtual Region VisibleContentOpaqueRegion() const OVERRIDE;
- virtual void DidLoseOutputSurface() OVERRIDE;
+ virtual void ReleaseResources() OVERRIDE;
const LayerTilingData* TilingForTesting() const { return tiler_.get(); }
diff --git a/cc/layers/video_layer_impl.cc b/cc/layers/video_layer_impl.cc
index 314fed6..dc67fc5 100644
--- a/cc/layers/video_layer_impl.cc
+++ b/cc/layers/video_layer_impl.cc
@@ -297,7 +297,7 @@ void VideoLayerImpl::DidDraw(ResourceProvider* resource_provider) {
provider_client_impl_->ReleaseLock();
}
-void VideoLayerImpl::DidLoseOutputSurface() {
+void VideoLayerImpl::ReleaseResources() {
updater_.reset();
}
diff --git a/cc/layers/video_layer_impl.h b/cc/layers/video_layer_impl.h
index b4df141..f8df7cbd 100644
--- a/cc/layers/video_layer_impl.h
+++ b/cc/layers/video_layer_impl.h
@@ -37,7 +37,7 @@ class CC_EXPORT VideoLayerImpl : public LayerImpl {
AppendQuadsData* append_quads_data) OVERRIDE;
virtual void DidDraw(ResourceProvider* resource_provider) OVERRIDE;
virtual void DidBecomeActive() OVERRIDE;
- virtual void DidLoseOutputSurface() OVERRIDE;
+ virtual void ReleaseResources() OVERRIDE;
void SetNeedsRedraw();