diff options
| author | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-12 00:54:25 +0000 |
|---|---|---|
| committer | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-12 00:54:25 +0000 |
| commit | 744329cf9801e052f15c9697c3fcf57e7a3169b4 (patch) | |
| tree | 92d17439d43862570ac6357c283f82ff8c829e99 /cc/output/gl_renderer.h | |
| parent | 36a3cd62844159f91f542ae3657dd0ac24d7f5af (diff) | |
| download | chromium_src-744329cf9801e052f15c9697c3fcf57e7a3169b4.zip chromium_src-744329cf9801e052f15c9697c3fcf57e7a3169b4.tar.gz chromium_src-744329cf9801e052f15c9697c3fcf57e7a3169b4.tar.bz2 | |
Revert 210138 "Perform glReadPixels with PBOs in the gpu, if PBO..."
> Perform glReadPixels with PBOs in the gpu, if PBOs are available.
> Make GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM wait for readpixel transfers.
> PLEASE NOTE: glMapBuffer does not wait for the readpixels transfer to complete anymore.
> Nobody is currently relying on that behaviour.
> Update gl_helper.cc and gl_renderer.cc to use queries.
>
> This CL is the same as https://codereview.chromium.org/16831004/
> but includes fixes for:
> OutOfProcessPPAPITests.Graphics3D (removed a check in query_tracker.cc)
> GLReadbackTest.ReadPixelsWithPBO (removed, no longer a valid test)
> GLReadbackTest.ReadPixelsWithPBOAndQuery (now uses the correct query)
>
> BUG=249925
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209873
>
> Review URL: https://chromiumcodereview.appspot.com/18555006
TBR=hubbe@chromium.org
BUG=258169
Review URL: https://codereview.chromium.org/19029003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211274 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/output/gl_renderer.h')
| -rw-r--r-- | cc/output/gl_renderer.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/cc/output/gl_renderer.h b/cc/output/gl_renderer.h index 97ef0b0..bde4d71 100644 --- a/cc/output/gl_renderer.h +++ b/cc/output/gl_renderer.h @@ -201,7 +201,6 @@ class CC_EXPORT GLRenderer : public DirectRenderer { void FinishedReadback( const AsyncGetFramebufferPixelsCleanupCallback& cleanup_callback, unsigned source_buffer, - unsigned query, uint8_t* dest_pixels, gfx::Size size); void PassOnSkBitmap(scoped_ptr<SkBitmap> bitmap, |