diff options
author | dominikg@chromium.org <dominikg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-23 17:04:50 +0000 |
---|---|---|
committer | dominikg@chromium.org <dominikg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-23 17:04:50 +0000 |
commit | daea3d424f865ae7fc5720dea7b3c9565952a968 (patch) | |
tree | 0c6bf0ade3676ee7b735fbc0aa5e1872cef9475f /cc/output/output_surface.h | |
parent | f54f8ce7166114c58c6ecb92b6cc2a0f8bac0a2b (diff) | |
download | chromium_src-daea3d424f865ae7fc5720dea7b3c9565952a968.zip chromium_src-daea3d424f865ae7fc5720dea7b3c9565952a968.tar.gz chromium_src-daea3d424f865ae7fc5720dea7b3c9565952a968.tar.bz2 |
Rename BeginFrame to BeginMainFrame and BeginImplFrame (part 3).
Third patch in a series to rename BeginFrame. This patch focuses on
cc::ThreadProxy, cc::LayerTreeHost, cc::LayerTreeHostImpl, cc::OutputSurface
and it's related (sub)classes.
In the scheduler, the term 'BeginFrame' is used for both the main thread and the
impl thread. This can cause confusion if it's not obvious which one is being
refered to. To clarify this, we rename BeginFrame to BeginMainFrame and
BeginImplFrame, respectively.
BUG=261765
Review URL: https://codereview.chromium.org/35023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230453 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/output/output_surface.h')
-rw-r--r-- | cc/output/output_surface.h | 36 |
1 files changed, 18 insertions, 18 deletions
diff --git a/cc/output/output_surface.h b/cc/output/output_surface.h index 97e5744..83ee5fd 100644 --- a/cc/output/output_surface.h +++ b/cc/output/output_surface.h @@ -68,7 +68,7 @@ class CC_EXPORT OutputSurface : public FrameRateControllerClient { int max_frames_pending; bool deferred_gl_initialization; bool draw_and_swap_full_viewport_every_frame; - // This doesn't handle the <webview> case, but once BeginFrame is + // This doesn't handle the <webview> case, but once BeginImplFrame is // supported natively, we shouldn't need adjust_deadline_for_parent. bool adjust_deadline_for_parent; // Whether this output surface renders to the default OpenGL zero @@ -104,7 +104,7 @@ class CC_EXPORT OutputSurface : public FrameRateControllerClient { // thread. virtual bool BindToClient(OutputSurfaceClient* client); - void InitializeBeginFrameEmulation( + void InitializeBeginImplFrameEmulation( base::SingleThreadTaskRunner* task_runner, bool throttle_frame_production, base::TimeDelta interval); @@ -128,10 +128,10 @@ class CC_EXPORT OutputSurface : public FrameRateControllerClient { // processing should be stopped, or lowered in priority. virtual void UpdateSmoothnessTakesPriority(bool prefer_smoothness) {} - // Requests a BeginFrame notification from the output surface. The + // Requests a BeginImplFrame notification from the output surface. The // notification will be delivered by calling - // OutputSurfaceClient::BeginFrame until the callback is disabled. - virtual void SetNeedsBeginFrame(bool enable); + // OutputSurfaceClient::BeginImplFrame until the callback is disabled. + virtual void SetNeedsBeginImplFrame(bool enable); bool HasClient() { return !!client_; } @@ -160,7 +160,7 @@ class CC_EXPORT OutputSurface : public FrameRateControllerClient { float device_scale_factor_; // The FrameRateController is deprecated. - // Platforms should move to native BeginFrames instead. + // Platforms should move to native BeginImplFrames instead. void OnVSyncParametersChanged(base::TimeTicks timebase, base::TimeDelta interval); virtual void FrameRateControllerTick(bool throttled, @@ -168,17 +168,17 @@ class CC_EXPORT OutputSurface : public FrameRateControllerClient { scoped_ptr<FrameRateController> frame_rate_controller_; int max_frames_pending_; int pending_swap_buffers_; - bool needs_begin_frame_; - bool client_ready_for_begin_frame_; + bool needs_begin_impl_frame_; + bool client_ready_for_begin_impl_frame_; - // This stores a BeginFrame that we couldn't process immediately, but might - // process retroactively in the near future. - BeginFrameArgs skipped_begin_frame_args_; + // This stores a BeginImplFrame that we couldn't process immediately, + // but might process retroactively in the near future. + BeginFrameArgs skipped_begin_impl_frame_args_; // Forwarded to OutputSurfaceClient but threaded through OutputSurface // first so OutputSurface has a chance to update the FrameRateController void SetNeedsRedrawRect(gfx::Rect damage_rect); - void BeginFrame(const BeginFrameArgs& args); + void BeginImplFrame(const BeginFrameArgs& args); void DidSwapBuffers(); void OnSwapBuffersComplete(); void ReclaimResources(const CompositorFrameAck* ack); @@ -190,9 +190,9 @@ class CC_EXPORT OutputSurface : public FrameRateControllerClient { bool valid_for_tile_management); // virtual for testing. - virtual base::TimeTicks RetroactiveBeginFrameDeadline(); - virtual void PostCheckForRetroactiveBeginFrame(); - void CheckForRetroactiveBeginFrame(); + virtual base::TimeTicks RetroactiveBeginImplFrameDeadline(); + virtual void PostCheckForRetroactiveBeginImplFrame(); + void CheckForRetroactiveBeginImplFrame(); private: OutputSurfaceClient* client_; @@ -204,9 +204,9 @@ class CC_EXPORT OutputSurface : public FrameRateControllerClient { bool discard_backbuffer_when_not_visible); void UpdateAndMeasureGpuLatency(); - // check_for_retroactive_begin_frame_pending_ is used to avoid posting - // redundant checks for a retroactive BeginFrame. - bool check_for_retroactive_begin_frame_pending_; + // check_for_retroactive_begin_impl_frame_pending_ is used to avoid posting + // redundant checks for a retroactive BeginImplFrame. + bool check_for_retroactive_begin_impl_frame_pending_; bool external_stencil_test_enabled_; |