diff options
| author | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-31 22:48:14 +0000 |
|---|---|---|
| committer | piman@chromium.org <piman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-31 22:48:14 +0000 |
| commit | f4bc734c6260722c782535aeded55967bb3162d3 (patch) | |
| tree | cf3c55bb3c71ea7b43609604be9ec69e31691c0e /cc/render_pass_draw_quad.h | |
| parent | dbfe3dc13a70c2b4bf8aec2c61a7c6d5868db846 (diff) | |
| download | chromium_src-f4bc734c6260722c782535aeded55967bb3162d3.zip chromium_src-f4bc734c6260722c782535aeded55967bb3162d3.tar.gz chromium_src-f4bc734c6260722c782535aeded55967bb3162d3.tar.bz2 | |
Fix DrawQuad copy
Creating a copy of the quads by allocating a bag of bytes is problematic because
the delete doesn't match the new (new [] vs scalar delete), which is wrong in
general but in particular causes asserts in tcmalloc and ASAN.
Instead, do the proper C++ version, relying on implicit copy constructors.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11344050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165248 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/render_pass_draw_quad.h')
| -rw-r--r-- | cc/render_pass_draw_quad.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/cc/render_pass_draw_quad.h b/cc/render_pass_draw_quad.h index 67955b0..5bb22ab 100644 --- a/cc/render_pass_draw_quad.h +++ b/cc/render_pass_draw_quad.h @@ -41,8 +41,6 @@ private: float m_maskTexCoordScaleY; float m_maskTexCoordOffsetX; float m_maskTexCoordOffsetY; - - DISALLOW_COPY_AND_ASSIGN(RenderPassDrawQuad); }; } |