diff options
| author | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
|---|---|---|
| committer | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
| commit | 0023fc78d056556b353ee17f03760bec8c1fee49 (patch) | |
| tree | 009367358a1c44b08f3142f63b087d936206ba44 /cc/resources/image_layer_updater.cc | |
| parent | 37df32bd517577ac6ad20c6d76b236265caeacaf (diff) | |
| download | chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.zip chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.gz chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.bz2 | |
Pass gfx::Rect and gfx::RectF by const ref.
Avoid unneccessary copy of structures gfx::Rect & gfx::RectF
by passing them by const ref rather than value.
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.
Pass by value creates unneccessary overhead which should be avoided.
BUG=159273
Review URL: https://codereview.chromium.org/93663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/resources/image_layer_updater.cc')
| -rw-r--r-- | cc/resources/image_layer_updater.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cc/resources/image_layer_updater.cc b/cc/resources/image_layer_updater.cc index 470f518..e6900b7 100644 --- a/cc/resources/image_layer_updater.cc +++ b/cc/resources/image_layer_updater.cc @@ -15,7 +15,7 @@ ImageLayerUpdater::Resource::Resource(ImageLayerUpdater* updater, ImageLayerUpdater::Resource::~Resource() {} void ImageLayerUpdater::Resource::Update(ResourceUpdateQueue* queue, - gfx::Rect source_rect, + const gfx::Rect& source_rect, gfx::Vector2d dest_offset, bool partial_update) { updater_->UpdateTexture( @@ -35,7 +35,7 @@ scoped_ptr<LayerUpdater::Resource> ImageLayerUpdater::CreateResource( void ImageLayerUpdater::UpdateTexture(ResourceUpdateQueue* queue, PrioritizedResource* texture, - gfx::Rect source_rect, + const gfx::Rect& source_rect, gfx::Vector2d dest_offset, bool partial_update) { // Source rect should never go outside the image pixels, even if this |