diff options
author | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-10 23:05:01 +0000 |
---|---|---|
committer | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-10 23:05:01 +0000 |
commit | e51444acccf0aeeeed78d0a9795016e26013e1a1 (patch) | |
tree | 358fba3fd6a996a2de9814bd5fd78ab204b5cd7a /cc/resources/resource_pool.h | |
parent | a269ade545f74e075b8fff7ca5b7f2edf32369d0 (diff) | |
download | chromium_src-e51444acccf0aeeeed78d0a9795016e26013e1a1.zip chromium_src-e51444acccf0aeeeed78d0a9795016e26013e1a1.tar.gz chromium_src-e51444acccf0aeeeed78d0a9795016e26013e1a1.tar.bz2 |
cc: Add PRESUBMIT rule to ban using cc:: inside of namespace cc {...}
This also makes cc/ PRESUBMIT clean for the new check.
The most invasive changes were:
1. Moving the cc/test/paths.h enum into a CCPaths class (named with
CC prefix to clarify this path is for CC since the enum is extending
an enum from base/.
2. Merge ResourcePool::Resource up into ScopedResource which was the
same thing basically.
R=enne
BUG=
Review URL: https://codereview.chromium.org/109263003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239904 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/resources/resource_pool.h')
-rw-r--r-- | cc/resources/resource_pool.h | 23 |
1 files changed, 5 insertions, 18 deletions
diff --git a/cc/resources/resource_pool.h b/cc/resources/resource_pool.h index 74175ed..3c6b23f 100644 --- a/cc/resources/resource_pool.h +++ b/cc/resources/resource_pool.h @@ -14,23 +14,10 @@ #include "cc/resources/resource_format.h" namespace cc { +class ScopedResource; class CC_EXPORT ResourcePool { public: - class CC_EXPORT Resource : public cc::Resource { - public: - Resource(ResourceProvider* resource_provider, - gfx::Size size, - GLenum target, - ResourceFormat format); - ~Resource(); - - private: - ResourceProvider* resource_provider_; - - DISALLOW_COPY_AND_ASSIGN(Resource); - }; - static scoped_ptr<ResourcePool> Create(ResourceProvider* resource_provider, GLenum target, ResourceFormat format) { @@ -41,8 +28,8 @@ class CC_EXPORT ResourcePool { virtual ~ResourcePool(); - scoped_ptr<ResourcePool::Resource> AcquireResource(gfx::Size size); - void ReleaseResource(scoped_ptr<ResourcePool::Resource>); + scoped_ptr<ScopedResource> AcquireResource(gfx::Size size); + void ReleaseResource(scoped_ptr<ScopedResource>); void SetResourceUsageLimits(size_t max_memory_usage_bytes, size_t max_unused_memory_usage_bytes, @@ -69,7 +56,7 @@ class CC_EXPORT ResourcePool { bool ResourceUsageTooHigh(); private: - void DidFinishUsingResource(ResourcePool::Resource* resource); + void DidFinishUsingResource(ScopedResource* resource); ResourceProvider* resource_provider_; const GLenum target_; @@ -81,7 +68,7 @@ class CC_EXPORT ResourcePool { size_t unused_memory_usage_bytes_; size_t resource_count_; - typedef std::list<Resource*> ResourceList; + typedef std::list<ScopedResource*> ResourceList; ResourceList unused_resources_; ResourceList busy_resources_; |