diff options
| author | danakj <danakj@chromium.org> | 2015-04-23 13:11:44 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-23 20:13:02 +0000 |
| commit | ba47f5a1c88309ee39f2c5befe91119a45a630d8 (patch) | |
| tree | 8f07abee04ce1ac9d8d333a68e8ad57cf695f0a9 /cc/resources | |
| parent | ce89b915d34a6bbe645da530b61bc3461e49f70f (diff) | |
| download | chromium_src-ba47f5a1c88309ee39f2c5befe91119a45a630d8.zip chromium_src-ba47f5a1c88309ee39f2c5befe91119a45a630d8.tar.gz chromium_src-ba47f5a1c88309ee39f2c5befe91119a45a630d8.tar.bz2 | |
cc: Turn ResourceProvider::ValidateResources into DCHECK-only code.
These CHECKs have helped us find the bugs we were searching for, so we
can make them DCHECKs now. I've opted to keep around DCHECKs rather
than removing it entirely, as crashing during swap instead of inside
AppendQuads is really hard to debug.
R=enne@chromium.org, piman@chromium.org
BUG=475894
Review URL: https://codereview.chromium.org/1084433003
Cr-Commit-Position: refs/heads/master@{#326622}
Diffstat (limited to 'cc/resources')
| -rw-r--r-- | cc/resources/resource_provider.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc index 7987f81..a336d75 100644 --- a/cc/resources/resource_provider.cc +++ b/cc/resources/resource_provider.cc @@ -2046,9 +2046,8 @@ GLint ResourceProvider::GetActiveTextureUnit(GLES2Interface* gl) { void ResourceProvider::ValidateResource(ResourceId id) { DCHECK(thread_checker_.CalledOnValidThread()); - CHECK(id); - ResourceMap::iterator it = resources_.find(id); - CHECK(it != resources_.end()); + DCHECK(id); + DCHECK(resources_.find(id) != resources_.end()); } GLES2Interface* ResourceProvider::ContextGL() const { |