diff options
| author | ccameron <ccameron@chromium.org> | 2015-04-01 13:36:28 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-01 20:37:13 +0000 |
| commit | 05840e8b1330f1bf19ca81a873616b75cc04a874 (patch) | |
| tree | 4b8069b8ac4fb1e83285c4c98fcb6f36ab0db822 /cc/scheduler/scheduler_state_machine_unittest.cc | |
| parent | 399e116bfbf7c0b7457981ad8f07e33f020baa03 (diff) | |
| download | chromium_src-05840e8b1330f1bf19ca81a873616b75cc04a874.zip chromium_src-05840e8b1330f1bf19ca81a873616b75cc04a874.tar.gz chromium_src-05840e8b1330f1bf19ca81a873616b75cc04a874.tar.bz2 | |
Make cc::Scheduler::BeginFrameNeeded be false when commits deferred
If this is not the case, then the scheduler will tick its |frame_source_|
until commits are re-enabled.
This is problematic because (on Mac) ui::Compositors that are not visible
because they are occluded by other NSWindows have commits deferred
until they are un-occluded. In the unintended endings department, this
makes the use of occlusion, intended to save power, end up consuming
more substantially more power.
BUG=471863
Review URL: https://codereview.chromium.org/1047173003
Cr-Commit-Position: refs/heads/master@{#323320}
Diffstat (limited to 'cc/scheduler/scheduler_state_machine_unittest.cc')
| -rw-r--r-- | cc/scheduler/scheduler_state_machine_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cc/scheduler/scheduler_state_machine_unittest.cc b/cc/scheduler/scheduler_state_machine_unittest.cc index 4c2c267..ba184e5 100644 --- a/cc/scheduler/scheduler_state_machine_unittest.cc +++ b/cc/scheduler/scheduler_state_machine_unittest.cc @@ -1818,7 +1818,7 @@ TEST(SchedulerStateMachineTest, TestDeferCommit) { state.SetDeferCommits(true); state.SetNeedsCommit(); - EXPECT_TRUE(state.BeginFrameNeeded()); + EXPECT_FALSE(state.BeginFrameNeeded()); EXPECT_ACTION_UPDATE_STATE(SchedulerStateMachine::ACTION_NONE); state.OnBeginImplFrame(); |