diff options
| author | alexst <alexst@chromium.org> | 2015-04-09 10:22:13 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-09 17:22:50 +0000 |
| commit | faa924ff38e80006a27ac85fcc95f3dcbe441d55 (patch) | |
| tree | a628fd7a4f24edbce9ea721b4532aae16dcc3f6a /cc/scheduler/scheduler_state_machine_unittest.cc | |
| parent | d5357318c3a5ac736106bdb86c5116997b12e0d0 (diff) | |
| download | chromium_src-faa924ff38e80006a27ac85fcc95f3dcbe441d55.zip chromium_src-faa924ff38e80006a27ac85fcc95f3dcbe441d55.tar.gz chromium_src-faa924ff38e80006a27ac85fcc95f3dcbe441d55.tar.bz2 | |
Remove swap ack throttling to regain performance regression on freon.
In the past eglSwapBuffers used to return early, before the swap actually happened and descheduling in the driver. This resulted in the scheduler beginning the next frame early and hitting the page flip deadline in time more often.
Freon returns swap ack when page flip actually happened, but with the side effect of scheduling shifted forward, resulting in more missed vblanks and reduced performance.
This change restores original performance on freon.
BUG=465599
Review URL: https://codereview.chromium.org/1053153003
Cr-Commit-Position: refs/heads/master@{#324465}
Diffstat (limited to 'cc/scheduler/scheduler_state_machine_unittest.cc')
| -rw-r--r-- | cc/scheduler/scheduler_state_machine_unittest.cc | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/cc/scheduler/scheduler_state_machine_unittest.cc b/cc/scheduler/scheduler_state_machine_unittest.cc index 7b332a3..878a52e 100644 --- a/cc/scheduler/scheduler_state_machine_unittest.cc +++ b/cc/scheduler/scheduler_state_machine_unittest.cc @@ -1780,16 +1780,6 @@ TEST(SchedulerStateMachineTest, TestImplLatencyTakesPriority) { // Finish the previous commit and draw it. FinishPreviousCommitAndDrawWithoutExitingDeadline(&state); EXPECT_ACTION_UPDATE_STATE(SchedulerStateMachine::ACTION_NONE); - - // Verify we do not send another BeginMainFrame if was are swap throttled - // and did not just swap. - state.SetNeedsCommit(); - EXPECT_ACTION_UPDATE_STATE(SchedulerStateMachine::ACTION_NONE); - state.OnBeginImplFrame(); - EXPECT_ACTION_UPDATE_STATE(SchedulerStateMachine::ACTION_NONE); - EXPECT_FALSE(state.ShouldTriggerBeginImplFrameDeadlineImmediately()); - state.OnBeginImplFrameDeadline(); - EXPECT_ACTION_UPDATE_STATE(SchedulerStateMachine::ACTION_NONE); } TEST(SchedulerStateMachineTest, |