diff options
author | ilevy@chromium.org <ilevy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-17 06:40:50 +0000 |
---|---|---|
committer | ilevy@chromium.org <ilevy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-17 06:40:50 +0000 |
commit | 3543975945a5667aa3fb48c6d0e1b6312d1ed293 (patch) | |
tree | a6ea1e1c640c6e9121a4e2ef066e1f235868099e /cc/scrollbar_layer_impl.cc | |
parent | 88b2f1aa74e8fe0b4413a4f807681fd427071184 (diff) | |
download | chromium_src-3543975945a5667aa3fb48c6d0e1b6312d1ed293.zip chromium_src-3543975945a5667aa3fb48c6d0e1b6312d1ed293.tar.gz chromium_src-3543975945a5667aa3fb48c6d0e1b6312d1ed293.tar.bz2 |
Revert 177288
> cc: Add point-based UV coordinate on TextureLayer
>
> Previously, the uv coordinates was using gfx::RectF as a struct.
> This was limitating because it could not handle negative width
> and heights. Soring them as 2 gfx::PointF for the Top-Left and
> Bottom-Right points aleviate that restriction.
> The current implementation of the phone UI rely on this feature.
>
> BUG=168927
>
> Review URL: https://chromiumcodereview.appspot.com/11783094
This is breaking the android internal chrome build, we need green for
a release cut later tonight. Let's reland tomorrow with the
corresponding downstream fix.
TBR=jscholler@chromium.org
Review URL: https://codereview.chromium.org/11959026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177360 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/scrollbar_layer_impl.cc')
-rw-r--r-- | cc/scrollbar_layer_impl.cc | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/cc/scrollbar_layer_impl.cc b/cc/scrollbar_layer_impl.cc index 67344ce..a42ff17 100644 --- a/cc/scrollbar_layer_impl.cc +++ b/cc/scrollbar_layer_impl.cc @@ -117,8 +117,7 @@ void ScrollbarLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData& append { bool premultipledAlpha = false; bool flipped = false; - gfx::PointF uvTopLeft(0.f, 0.f); - gfx::PointF uvBottomRight(1.f, 1.f); + gfx::RectF uvRect(0, 0, 1, 1); gfx::Rect boundsRect(gfx::Point(), bounds()); gfx::Rect contentBoundsRect(gfx::Point(), contentBounds()); @@ -135,7 +134,7 @@ void ScrollbarLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData& append gfx::Rect opaqueRect; const float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f}; scoped_ptr<TextureDrawQuad> quad = TextureDrawQuad::Create(); - quad->SetNew(sharedQuadState, quadRect, opaqueRect, m_thumbResourceId, premultipledAlpha, uvTopLeft, uvBottomRight, opacity, flipped); + quad->SetNew(sharedQuadState, quadRect, opaqueRect, m_thumbResourceId, premultipledAlpha, uvRect, opacity, flipped); quadSink.append(quad.PassAs<DrawQuad>(), appendQuadsData); } @@ -146,10 +145,9 @@ void ScrollbarLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData& append if (m_foreTrackResourceId && !foreTrackRect.isEmpty()) { gfx::Rect quadRect(scrollbarLayerRectToContentRect(foreTrackRect)); gfx::Rect opaqueRect(contentsOpaque() ? quadRect : gfx::Rect()); - gfx::RectF uvRect(toUVRect(foreTrackRect, boundsRect)); const float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f}; scoped_ptr<TextureDrawQuad> quad = TextureDrawQuad::Create(); - quad->SetNew(sharedQuadState, quadRect, opaqueRect, m_foreTrackResourceId, premultipledAlpha, uvRect.origin(), uvRect.bottom_right(), opacity, flipped); + quad->SetNew(sharedQuadState, quadRect, opaqueRect, m_foreTrackResourceId, premultipledAlpha, toUVRect(foreTrackRect, boundsRect), opacity, flipped); quadSink.append(quad.PassAs<DrawQuad>(), appendQuadsData); } @@ -160,7 +158,7 @@ void ScrollbarLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData& append gfx::Rect opaqueRect(contentsOpaque() ? quadRect : gfx::Rect()); const float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f}; scoped_ptr<TextureDrawQuad> quad = TextureDrawQuad::Create(); - quad->SetNew(sharedQuadState, quadRect, opaqueRect, m_backTrackResourceId, premultipledAlpha, uvTopLeft, uvBottomRight, opacity, flipped); + quad->SetNew(sharedQuadState, quadRect, opaqueRect, m_backTrackResourceId, premultipledAlpha, uvRect, opacity, flipped); quadSink.append(quad.PassAs<DrawQuad>(), appendQuadsData); } } |