summaryrefslogtreecommitdiffstats
path: root/cc/stubs
diff options
context:
space:
mode:
authorjamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-05 05:41:49 +0000
committerjamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-05 05:41:49 +0000
commit267f784a18083e0aa58e28766cba595fd543dae9 (patch)
tree2d71c6ac8ce583ace4288270a4421ccbcab37492 /cc/stubs
parent4a77788972805e5573f7787b25e3f185e61560f6 (diff)
downloadchromium_src-267f784a18083e0aa58e28766cba595fd543dae9.zip
chromium_src-267f784a18083e0aa58e28766cba595fd543dae9.tar.gz
chromium_src-267f784a18083e0aa58e28766cba595fd543dae9.tar.bz2
Fix up cc stubs and bindings to work in windows
Windows is stricter than other platforms in a few ways: *) All files referenced in a .gyp have to actually exist or the generator complains *) Symbols have to be defined in only one object file *) NO_ERROR is #defined by some win32 headers and collides with GL headers *) WEBKIT_DLL has to be set for targets that define exported symbols This fixes these in the cc stubs. BUG= Review URL: https://chromiumcodereview.appspot.com/10915074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154899 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/stubs')
-rw-r--r--cc/stubs/GraphicsContext3D.h11
-rw-r--r--cc/stubs/TextStream.h9
2 files changed, 10 insertions, 10 deletions
diff --git a/cc/stubs/GraphicsContext3D.h b/cc/stubs/GraphicsContext3D.h
index 41404f2..eff588e 100644
--- a/cc/stubs/GraphicsContext3D.h
+++ b/cc/stubs/GraphicsContext3D.h
@@ -9,17 +9,16 @@
#include "IntSize.h"
#include "third_party/khronos/GLES2/gl2.h"
+#ifdef NO_ERROR
+#undef NO_ERROR
+#endif
+
namespace WebCore {
class GraphicsContext3D {
public:
enum SourceDataFormat { SourceFormatRGBA8, SourceFormatBGRA8 };
- static bool computeFormatAndTypeParameters(unsigned, unsigned, unsigned* componentsPerPixel, unsigned* bytesPerComponent)
- {
- *componentsPerPixel = 4;
- *bytesPerComponent = 1;
- return true;
- }
+ static bool computeFormatAndTypeParameters(unsigned, unsigned, unsigned* componentsPerPixel, unsigned* bytesPerComponent);
enum {
ARRAY_BUFFER = GL_ARRAY_BUFFER,
diff --git a/cc/stubs/TextStream.h b/cc/stubs/TextStream.h
index a9d02d6..8ed4fbb 100644
--- a/cc/stubs/TextStream.h
+++ b/cc/stubs/TextStream.h
@@ -9,12 +9,13 @@
namespace WebCore {
+// These symbols are all defined inside WebCore.
class TextStream {
public:
- TextStream& operator<<(const String&) { return *this; }
- TextStream& operator<<(const char*) { return *this; }
- TextStream& operator<<(int) { return *this; }
- String release() { return ""; }
+ TextStream& operator<<(const String&);
+ TextStream& operator<<(const char*);
+ TextStream& operator<<(int);
+ String release();
};
}