diff options
| author | scottmg@chromium.org <scottmg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-04 23:42:56 +0000 |
|---|---|---|
| committer | scottmg@chromium.org <scottmg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-04 23:42:56 +0000 |
| commit | be6dedf67bfdaf94c64e3a853e8491582905dd19 (patch) | |
| tree | cccc95d45169effea10a2e8b84237200771b9da9 /cc/test/fake_content_layer_client.h | |
| parent | d3ba08d9ead26a59ae5503ca7f175c5a6046f2cc (diff) | |
| download | chromium_src-be6dedf67bfdaf94c64e3a853e8491582905dd19.zip chromium_src-be6dedf67bfdaf94c64e3a853e8491582905dd19.tar.gz chromium_src-be6dedf67bfdaf94c64e3a853e8491582905dd19.tar.bz2 | |
Revert 261906 "cc: Add picture recording modes for benchmarking"
Suspected of causing gcm_unit_tests failures
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.7%20Tests%20%282%29&number=25118
Will file a bug that gcm_unit_tests isn't in default tryjob set if this is actually the cause.
> cc: Add picture recording modes for benchmarking
>
> This patch adds three different picture recording modes for benchmarking
> purposes:
>
> 1. RECORD_NORMALLY. This is the default and produces a normal recording
> as before.
>
> 2. RECORD_WITH_NULL_CANVAS. This mode uses SkNullCanvas to avoid (most
> of) the Skia processing that happen during recording. Can be used to
> estimate the recording workload inside Blink.
>
> 3. RECORD_WITH_PAINTING_DISABLED. Passes a NULL canvas to Blink, which
> causes the GraphicsContext object to disable painting. This mode
> gives an estimate of the recording workload of Blink excluding the
> processing inside GraphicsContext.
>
> This patch also modifies the rasterize_and_record_micro benchmark to
> report the recording time for each mode (record_time_ms,
> record_time_null_canvas_ms and record_time_painting_disabled_ms
> respectively).
>
> Anecdotally on a z600 and the key_silk_cases page set, SkNullCanvas cuts
> recording time to 50% and disabling painting down to 19%.
>
> BUG=357572
> TEST=PictureTest.RecordingModes
> TEST=tools/perf/run_benchmark rasterize_and_record_micro.key_silk_cases --browser=release
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261543
>
> Review URL: https://codereview.chromium.org/216933002
TBR=skyostil@chromium.org
Review URL: https://codereview.chromium.org/226083007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261914 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/fake_content_layer_client.h')
| -rw-r--r-- | cc/test/fake_content_layer_client.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/cc/test/fake_content_layer_client.h b/cc/test/fake_content_layer_client.h index 1a5221f..8410f3e 100644 --- a/cc/test/fake_content_layer_client.h +++ b/cc/test/fake_content_layer_client.h @@ -49,8 +49,6 @@ class FakeContentLayerClient : public ContentLayerClient { draw_bitmaps_.push_back(data); } - SkCanvas* last_canvas() const { return last_canvas_; } - private: typedef std::vector<std::pair<gfx::RectF, SkPaint> > RectPaintVector; typedef std::vector<BitmapData> BitmapVector; @@ -58,7 +56,6 @@ class FakeContentLayerClient : public ContentLayerClient { bool paint_all_opaque_; RectPaintVector draw_rects_; BitmapVector draw_bitmaps_; - SkCanvas* last_canvas_; }; } // namespace cc |