diff options
| author | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-03 22:47:42 +0000 |
|---|---|---|
| committer | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-03 22:47:42 +0000 |
| commit | cdc429bc73d472d0356a984a1ab338fbba3e0809 (patch) | |
| tree | ee0565ad8611ad5377720d9b86c9e7f1fab4acc5 /cc/test/fake_content_layer_client.h | |
| parent | 04ba1825f498cc4db75dcbb80e01682231a104d3 (diff) | |
| download | chromium_src-cdc429bc73d472d0356a984a1ab338fbba3e0809.zip chromium_src-cdc429bc73d472d0356a984a1ab338fbba3e0809.tar.gz chromium_src-cdc429bc73d472d0356a984a1ab338fbba3e0809.tar.bz2 | |
Revert 261543 "cc: Add picture recording modes for benchmarking"
> cc: Add picture recording modes for benchmarking
>
> This patch adds three different picture recording modes for benchmarking
> purposes:
>
> 1. RECORD_NORMALLY. This is the default and produces a normal recording
> as before.
>
> 2. RECORD_WITH_NULL_CANVAS. This mode uses SkNullCanvas to avoid (most
> of) the Skia processing that happen during recording. Can be used to
> estimate the recording workload inside Blink.
>
> 3. RECORD_WITH_PAINTING_DISABLED. Passes a NULL canvas to Blink, which
> causes the GraphicsContext object to disable painting. This mode
> gives an estimate of the recording workload of Blink excluding the
> processing inside GraphicsContext.
>
> This patch also modifies the rasterize_and_record_micro benchmark to
> report the recording time for each mode (record_time_ms,
> record_time_null_canvas_ms and record_time_painting_disabled_ms
> respectively).
>
> Anecdotally on a z600 and the key_silk_cases page set, SkNullCanvas cuts
> recording time to 50% and disabling painting down to 19%.
>
> BUG=357572
> TEST=PictureTest.RecordingModes
> TEST=tools/perf/run_benchmark rasterize_and_record_micro.key_silk_cases --browser=release
>
> Review URL: https://codereview.chromium.org/216933002
TBR=skyostil@chromium.org
Review URL: https://codereview.chromium.org/224683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261556 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/fake_content_layer_client.h')
| -rw-r--r-- | cc/test/fake_content_layer_client.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/cc/test/fake_content_layer_client.h b/cc/test/fake_content_layer_client.h index 1a5221f..8410f3e 100644 --- a/cc/test/fake_content_layer_client.h +++ b/cc/test/fake_content_layer_client.h @@ -49,8 +49,6 @@ class FakeContentLayerClient : public ContentLayerClient { draw_bitmaps_.push_back(data); } - SkCanvas* last_canvas() const { return last_canvas_; } - private: typedef std::vector<std::pair<gfx::RectF, SkPaint> > RectPaintVector; typedef std::vector<BitmapData> BitmapVector; @@ -58,7 +56,6 @@ class FakeContentLayerClient : public ContentLayerClient { bool paint_all_opaque_; RectPaintVector draw_rects_; BitmapVector draw_bitmaps_; - SkCanvas* last_canvas_; }; } // namespace cc |