diff options
| author | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
|---|---|---|
| committer | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
| commit | 0023fc78d056556b353ee17f03760bec8c1fee49 (patch) | |
| tree | 009367358a1c44b08f3142f63b087d936206ba44 /cc/test/fake_picture_layer_tiling_client.h | |
| parent | 37df32bd517577ac6ad20c6d76b236265caeacaf (diff) | |
| download | chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.zip chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.gz chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.bz2 | |
Pass gfx::Rect and gfx::RectF by const ref.
Avoid unneccessary copy of structures gfx::Rect & gfx::RectF
by passing them by const ref rather than value.
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.
Pass by value creates unneccessary overhead which should be avoided.
BUG=159273
Review URL: https://codereview.chromium.org/93663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/fake_picture_layer_tiling_client.h')
| -rw-r--r-- | cc/test/fake_picture_layer_tiling_client.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cc/test/fake_picture_layer_tiling_client.h b/cc/test/fake_picture_layer_tiling_client.h index 4b092e8..2e4e9d6 100644 --- a/cc/test/fake_picture_layer_tiling_client.h +++ b/cc/test/fake_picture_layer_tiling_client.h @@ -22,7 +22,7 @@ class FakePictureLayerTilingClient : public PictureLayerTilingClient { // PictureLayerTilingClient implementation. virtual scoped_refptr<Tile> CreateTile( - PictureLayerTiling* tiling, gfx::Rect rect) OVERRIDE; + PictureLayerTiling* tiling, const gfx::Rect& rect) OVERRIDE; virtual void UpdatePile(Tile* tile) OVERRIDE {} virtual gfx::Size CalculateTileSize( gfx::Size content_bounds) const OVERRIDE; @@ -37,7 +37,7 @@ class FakePictureLayerTilingClient : public PictureLayerTilingClient { const PictureLayerTiling* tiling) const OVERRIDE; void set_twin_tiling(PictureLayerTiling* tiling) { twin_tiling_ = tiling; } - void set_text_rect(gfx::Rect rect) { text_rect_ = rect; } + void set_text_rect(const gfx::Rect& rect) { text_rect_ = rect; } void set_allow_create_tile(bool allow) { allow_create_tile_ = allow; } void set_invalidation(const Region& region) { invalidation_ = region; } |