diff options
| author | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-28 11:42:39 +0000 |
|---|---|---|
| committer | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-28 11:42:39 +0000 |
| commit | 2a58e14322fb357f248528b4b4c77e10fa53ae2d (patch) | |
| tree | 890aa3b6fe2416ca4c49786b3976f784332cea3b /cc/test/fake_picture_pile_impl.cc | |
| parent | e15ed2be6d44ab35e80ab71ec1d9e5eb459435eb (diff) | |
| download | chromium_src-2a58e14322fb357f248528b4b4c77e10fa53ae2d.zip chromium_src-2a58e14322fb357f248528b4b4c77e10fa53ae2d.tar.gz chromium_src-2a58e14322fb357f248528b4b4c77e10fa53ae2d.tar.bz2 | |
Revert of [#7] Pass gfx structs by const ref (gfx::Size) (https://codereview.chromium.org/145313006/)
Reason for revert:
Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 )
Original issue's description:
> [#7] Pass gfx::Size by const ref.
>
> Any struct of size > 4 bytes should be passed by const ref.
> Passing by ref for these structs is faster than passing by value,
> especially when invoking function has multiple parameters and some
> other scenarios mentioned in the bug.
>
> BUG=159273
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426
TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=159273
Review URL: https://codereview.chromium.org/142863008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247437 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/fake_picture_pile_impl.cc')
| -rw-r--r-- | cc/test/fake_picture_pile_impl.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/cc/test/fake_picture_pile_impl.cc b/cc/test/fake_picture_pile_impl.cc index 9b168e6..bc751ed 100644 --- a/cc/test/fake_picture_pile_impl.cc +++ b/cc/test/fake_picture_pile_impl.cc @@ -17,8 +17,8 @@ FakePicturePileImpl::FakePicturePileImpl() {} FakePicturePileImpl::~FakePicturePileImpl() {} scoped_refptr<FakePicturePileImpl> FakePicturePileImpl::CreateFilledPile( - const gfx::Size& tile_size, - const gfx::Size& layer_bounds) { + gfx::Size tile_size, + gfx::Size layer_bounds) { scoped_refptr<FakePicturePileImpl> pile(new FakePicturePileImpl()); pile->tiling().SetTotalSize(layer_bounds); pile->tiling().SetMaxTextureSize(tile_size); @@ -32,8 +32,8 @@ scoped_refptr<FakePicturePileImpl> FakePicturePileImpl::CreateFilledPile( } scoped_refptr<FakePicturePileImpl> FakePicturePileImpl::CreateEmptyPile( - const gfx::Size& tile_size, - const gfx::Size& layer_bounds) { + gfx::Size tile_size, + gfx::Size layer_bounds) { scoped_refptr<FakePicturePileImpl> pile(new FakePicturePileImpl()); pile->tiling().SetTotalSize(layer_bounds); pile->tiling().SetMaxTextureSize(tile_size); @@ -44,8 +44,8 @@ scoped_refptr<FakePicturePileImpl> FakePicturePileImpl::CreateEmptyPile( scoped_refptr<FakePicturePileImpl> FakePicturePileImpl::CreatePileWithRecordedRegion( - const gfx::Size& tile_size, - const gfx::Size& layer_bounds, + gfx::Size tile_size, + gfx::Size layer_bounds, const Region& recorded_region) { scoped_refptr<FakePicturePileImpl> pile(new FakePicturePileImpl()); pile->tiling().SetTotalSize(layer_bounds); |