summaryrefslogtreecommitdiffstats
path: root/cc/test/fake_proxy.h
diff options
context:
space:
mode:
authormark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-17 16:35:31 +0000
committermark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-17 16:35:31 +0000
commit8b9e52b165fbebe563c9bf25ee711cf1e360f401 (patch)
tree58d3969e28f9c5744652439f93b011a677bd4a0b /cc/test/fake_proxy.h
parentd0af050029d377aba6d180858d6b8a018497eb35 (diff)
downloadchromium_src-8b9e52b165fbebe563c9bf25ee711cf1e360f401.zip
chromium_src-8b9e52b165fbebe563c9bf25ee711cf1e360f401.tar.gz
chromium_src-8b9e52b165fbebe563c9bf25ee711cf1e360f401.tar.bz2
Revert 245445 "Unifies LayerTreeHost::SetNeedsUpdateLayers and S..."
Speculative. This may have caused flakiness on multiple bots. See bug 335582. > Unifies LayerTreeHost::SetNeedsUpdateLayers and SetNeedsAnimate -- V2 > > [2/2] Unifies LayerTreeHost::SetNeedsUpdateLayers and SetNeedsAnimate > > They basically do the same thing except that SetNeedsAnimate makes the next > commit non-cancellable. However there is really no reason why SetNeedsAnimate > need to enforce a commit even if no tiles are updated and no layer properties > changed. > > SetNeedsAnimate is thus merged into SetNeedsUpdateLayers. The proper use of > it is when there are potential layout/tile changes, we can use it to defer > calculation until the next frame. A commit will be scheduled but can be > cancelled if no updates are needed after calculation. > > This part of the patch changes code behavior slightly. > SingleThreadProxy::SetNeedsUpdateLayers was originally implemented as > RenderWidget::ScheduleComposite but now it is RenderWidget::ScheduleAnimation. > ThreadProxy::SetNeedsAnimate was non-cancellable but is now cancellable. > > [1/2] Cleanup RenderWidget::scheduleComposite/scheduleAnimation > > scheduleComposite has been renamed to ScheduleComposite as it is no longer > a part of WebWidgetClient API. > > scheduleAnimation has been renamed to ScheduleAnimation. The semantics is to > schedule a composite and also (potentially) animating WebWidget. > > A new WebWidgetClient API scheduleUpdate has been added, to replace the old > scheduleAnimation. The semantics is to notify the embedder that something in > the WebWidget may change in 0 seconds. (i.e. it is allowed to be called > during a redraw, in such case another redraw will be scheduled after frame > delay. > > This part of the patch should not change code behavior. > > BUG=316929 > R=danakj,jamesr,jochen > > Review URL: https://codereview.chromium.org/133263004 TBR=trchen@chromium.org BUG=335582 Review URL: https://codereview.chromium.org/141833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245528 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/fake_proxy.h')
-rw-r--r--cc/test/fake_proxy.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/cc/test/fake_proxy.h b/cc/test/fake_proxy.h
index 9c495c0..cda4e72 100644
--- a/cc/test/fake_proxy.h
+++ b/cc/test/fake_proxy.h
@@ -29,6 +29,7 @@ class FakeProxy : public Proxy {
virtual void SetVisible(bool visible) OVERRIDE {}
virtual void CreateAndInitializeOutputSurface() OVERRIDE;
virtual const RendererCapabilities& GetRendererCapabilities() const OVERRIDE;
+ virtual void SetNeedsAnimate() OVERRIDE {}
virtual void SetNeedsUpdateLayers() OVERRIDE {}
virtual void SetNeedsCommit() OVERRIDE {}
virtual void SetNeedsRedraw(const gfx::Rect& damage_rect) OVERRIDE {}