diff options
| author | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
|---|---|---|
| committer | prashant.n@samsung.com <prashant.n@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-10 20:05:06 +0000 |
| commit | 0023fc78d056556b353ee17f03760bec8c1fee49 (patch) | |
| tree | 009367358a1c44b08f3142f63b087d936206ba44 /cc/test/layer_test_common.cc | |
| parent | 37df32bd517577ac6ad20c6d76b236265caeacaf (diff) | |
| download | chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.zip chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.gz chromium_src-0023fc78d056556b353ee17f03760bec8c1fee49.tar.bz2 | |
Pass gfx::Rect and gfx::RectF by const ref.
Avoid unneccessary copy of structures gfx::Rect & gfx::RectF
by passing them by const ref rather than value.
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.
Pass by value creates unneccessary overhead which should be avoided.
BUG=159273
Review URL: https://codereview.chromium.org/93663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/layer_test_common.cc')
| -rw-r--r-- | cc/test/layer_test_common.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cc/test/layer_test_common.cc b/cc/test/layer_test_common.cc index 3ccd0a4..0171999 100644 --- a/cc/test/layer_test_common.cc +++ b/cc/test/layer_test_common.cc @@ -19,7 +19,7 @@ namespace cc { // Align with expected and actual output. const char* LayerTestCommon::quad_string = " Quad: "; -static bool CanRectFBeSafelyRoundedToRect(gfx::RectF r) { +static bool CanRectFBeSafelyRoundedToRect(const gfx::RectF& r) { // Ensure that range of float values is not beyond integer range. if (!r.IsExpressibleAsRect()) return false; @@ -33,7 +33,7 @@ static bool CanRectFBeSafelyRoundedToRect(gfx::RectF r) { } void LayerTestCommon::VerifyQuadsExactlyCoverRect(const QuadList& quads, - gfx::Rect rect) { + const gfx::Rect& rect) { Region remaining = rect; for (size_t i = 0; i < quads.size(); ++i) { |