summaryrefslogtreecommitdiffstats
path: root/cc/test/pixel_test.cc
diff options
context:
space:
mode:
authormnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-28 11:42:39 +0000
committermnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-28 11:42:39 +0000
commit2a58e14322fb357f248528b4b4c77e10fa53ae2d (patch)
tree890aa3b6fe2416ca4c49786b3976f784332cea3b /cc/test/pixel_test.cc
parente15ed2be6d44ab35e80ab71ec1d9e5eb459435eb (diff)
downloadchromium_src-2a58e14322fb357f248528b4b4c77e10fa53ae2d.zip
chromium_src-2a58e14322fb357f248528b4b4c77e10fa53ae2d.tar.gz
chromium_src-2a58e14322fb357f248528b4b4c77e10fa53ae2d.tar.bz2
Revert of [#7] Pass gfx structs by const ref (gfx::Size) (https://codereview.chromium.org/145313006/)
Reason for revert: Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 ) Original issue's description: > [#7] Pass gfx::Size by const ref. > > Any struct of size > 4 bytes should be passed by const ref. > Passing by ref for these structs is faster than passing by value, > especially when invoking function has multiple parameters and some > other scenarios mentioned in the bug. > > BUG=159273 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426 TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com NOTREECHECKS=true NOTRY=true BUG=159273 Review URL: https://codereview.chromium.org/142863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247437 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/pixel_test.cc')
-rw-r--r--cc/test/pixel_test.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/cc/test/pixel_test.cc b/cc/test/pixel_test.cc
index e84540e..1257be6 100644
--- a/cc/test/pixel_test.cc
+++ b/cc/test/pixel_test.cc
@@ -137,7 +137,7 @@ void PixelTest::SetUpGLRenderer(bool use_skia_gpu_backend) {
0).PassAs<DirectRenderer>();
}
-void PixelTest::ForceExpandedViewport(const gfx::Size& surface_expansion) {
+void PixelTest::ForceExpandedViewport(gfx::Size surface_expansion) {
static_cast<PixelTestOutputSurface*>(output_surface_.get())
->set_surface_expansion_size(surface_expansion);
SoftwareOutputDevice* device = output_surface_->software_device();