diff options
| author | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-22 03:43:02 +0000 |
|---|---|---|
| committer | danakj@chromium.org <danakj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-22 03:43:02 +0000 |
| commit | c8d7155f2e7523afba19912e1801174411025067 (patch) | |
| tree | 071d8f4139b5f035573cc65653890898b3d081da /cc/test/render_pass_test_utils.cc | |
| parent | edbc750c54fa4a18bef5386bce35c276fd52f94a (diff) | |
| download | chromium_src-c8d7155f2e7523afba19912e1801174411025067.zip chromium_src-c8d7155f2e7523afba19912e1801174411025067.tar.gz chromium_src-c8d7155f2e7523afba19912e1801174411025067.tar.bz2 | |
cc: Stop using drawableContentRect for occlusion.
The occlusion tracker has been using the drawableContentRect() which is not
useful compared to the clipRect() unless queries go outside the bounds of
the layer (which they would not). Also, the tests would override and fake
out the layer drawableContentRect() instead of just making a clipRect()
with an appropriate tree hierarchy.
The unit tests are now more real, and set up clipping in legitimite ways,
and drawableContentRect() is no longer used.
This removes most of the usage of the drawableContentRect() outside of tests,
making it easier to remove it entirely in the future if we like.
Tested by all the occlusion tracker unit tests in cc_unittests.
TBR=cdn@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11871008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177974 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/test/render_pass_test_utils.cc')
| -rw-r--r-- | cc/test/render_pass_test_utils.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/cc/test/render_pass_test_utils.cc b/cc/test/render_pass_test_utils.cc index 4e5d6ad..b9f1217 100644 --- a/cc/test/render_pass_test_utils.cc +++ b/cc/test/render_pass_test_utils.cc @@ -33,7 +33,7 @@ SolidColorDrawQuad* addQuad(TestRenderPass* pass, AppendQuadsData data(pass->id); SharedQuadState* sharedState = quadSink.useSharedQuadState(SharedQuadState::Create()); - sharedState->SetAll(gfx::Transform(), rect, rect, rect, false, 1); + sharedState->SetAll(gfx::Transform(), rect, rect, false, 1); scoped_ptr<SolidColorDrawQuad> quad = SolidColorDrawQuad::Create(); quad->SetNew(sharedState, rect, color); SolidColorDrawQuad* quadPtr = quad.get(); @@ -48,8 +48,7 @@ void addRenderPassQuad(TestRenderPass* toPass, gfx::Rect outputRect = contributingPass->output_rect; SharedQuadState* sharedState = quadSink.useSharedQuadState(SharedQuadState::Create()); - sharedState->SetAll(gfx::Transform(), outputRect, outputRect, outputRect, - false, 1); + sharedState->SetAll(gfx::Transform(), outputRect, outputRect, false, 1); scoped_ptr<RenderPassDrawQuad> quad = RenderPassDrawQuad::Create(); quad->SetNew(sharedState, outputRect, contributingPass->id, false, 0, outputRect, gfx::RectF(), WebKit::WebFilterOperations(), |